This is an archive of the discontinued LLVM Phabricator instance.

Differential D104523

[hwasan] Clarify report for allocation-tail-overwritten.
ClosedPublic

Authored by fmayer on Jun 18 2021, 5:03 AM.

Details

Reviewers
eugenis
Commits
rGe0b68f7149f9: [hwasan] Clarify report for allocation-tail-overwritten.
Summary

Explain what the given stack trace means before showing it, rather than
only in the paragraph at the end.

Diff Detail

Event Timeline

fmayer requested review of this revision.Jun 18 2021, 5:03 AM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 5:03 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Jun 18 2021, 10:38 AM

LGTM

This revision is now accepted and ready to land.Jun 18 2021, 10:38 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 10:53 AM
Closed by commit rGe0b68f7149f9: [hwasan] Clarify report for allocation-tail-overwritten. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rGe0b68f7149f9: [hwasan] Clarify report for allocation-tail-overwritten..
Harbormaster completed remote builds in B109907: Diff 352978.Jun 18 2021, 7:03 PM

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
6 lines
test/
hwasan/
TestCases/
6 lines

Diff 353049

compiler-rt/lib/hwasan/hwasan_report.cpp

Show First 20 Lines • Show All 541 Lines • ▼ Show 20 Linesvoid ReportTailOverwritten(StackTrace *stack, uptr tagged_addr, uptr orig_size,
ScopedReport R(flags()->halt_on_error); ScopedReport R(flags()->halt_on_error);
Decorator d; Decorator d;
uptr untagged_addr = UntagAddr(tagged_addr); uptr untagged_addr = UntagAddr(tagged_addr);
Printf("%s", d.Error()); Printf("%s", d.Error());
const char *bug_type = "allocation-tail-overwritten"; const char *bug_type = "allocation-tail-overwritten";
Report("ERROR: %s: %s; heap object [%p,%p) of size %zd\n", SanitizerToolName, Report("ERROR: %s: %s; heap object [%p,%p) of size %zd\n", SanitizerToolName,
bug_type, untagged_addr, untagged_addr + orig_size, orig_size); bug_type, untagged_addr, untagged_addr + orig_size, orig_size);
Printf("\n%s", d.Default()); Printf("\n%s", d.Default());
Printf(
"Stack of invalid access unknown. Issue detected at deallocation "
"time.\n");
Printf("%s", d.Allocation());
Printf("deallocated here:\n");
Printf("%s", d.Default());
stack->Print(); stack->Print();
HwasanChunkView chunk = FindHeapChunkByAddress(untagged_addr); HwasanChunkView chunk = FindHeapChunkByAddress(untagged_addr);
if (chunk.Beg()) { if (chunk.Beg()) {
Printf("%s", d.Allocation()); Printf("%s", d.Allocation());
Printf("allocated here:\n"); Printf("allocated here:\n");
Printf("%s", d.Default()); Printf("%s", d.Default());
GetStackTraceFromId(chunk.GetAllocStackId()).Print(); GetStackTraceFromId(chunk.GetAllocStackId()).Print();
} }
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines

compiler-rt/test/hwasan/TestCases/tail-magic.c

Show All 21 Lines
int main(int argc, char **argv) { int main(int argc, char **argv) {
__hwasan_enable_allocator_tagging(); __hwasan_enable_allocator_tagging();
char *p = (char*)malloc(20); char *p = (char*)malloc(20);
sink = p; sink = p;
overwrite_tail(); overwrite_tail();
free(p); free(p);
// CHECK: ERROR: HWAddressSanitizer: allocation-tail-overwritten; heap object [{{.*}}) of size 20 // CHECK: ERROR: HWAddressSanitizer: allocation-tail-overwritten; heap object [{{.*}}) of size 20
// CHECK: in main {{.*}}tail-magic.c:[[@LINE-2]] // CHECK: Stack of invalid access unknown. Issue detected at deallocation time.
// CHECK: deallocated here:
// CHECK: in main {{.*}}tail-magic.c:[[@LINE-4]]
// CHECK: allocated here: // CHECK: allocated here:
// CHECK: in main {{.*}}tail-magic.c:[[@LINE-7]] // CHECK: in main {{.*}}tail-magic.c:[[@LINE-9]]
// CHECK: Tail contains: .. .. .. .. 42 {{.. .. ..}} 66 // CHECK: Tail contains: .. .. .. .. 42 {{.. .. ..}} 66
} }