This is an archive of the discontinued LLVM Phabricator instance.

Differential D10438

[mips] Disable frame_layout test on Mips16.
ClosedPublic

Authored by vkalintiris on Jun 15 2015, 6:51 AM.

Details

Reviewers
dsanders
Commits
rOLDT242664: [mips] Disable frame_layout test on Mips16.
rL242664: [mips] Disable frame_layout test on Mips16.
Summary

The frame_layout test requires support for dynamic stack realignment which
is not available on targets without standard encoding.

Diff Detail

Event Timeline

vkalintiris updated this revision to Diff 27668.Jun 15 2015, 6:51 AM
vkalintiris retitled this revision from to [mips] Disable frame_layout test on Mips16..
vkalintiris updated this object.
vkalintiris edited the test plan for this revision. (Show Details)
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: Unknown Object (MLST).
dsanders accepted this revision.Jun 15 2015, 9:35 AM
dsanders edited edge metadata.

LGTM.

If it doesn't already do so, could you also make Mips16 report an error if it tries to dynamically realign the stack (i.e. the frame alignment is greater than the normal stack alignment)?

This revision is now accepted and ready to land.Jun 15 2015, 9:35 AM
Closed by commit rL242664: [mips] Disable frame_layout test on Mips16. (authored by vkalintiris). · Explain WhyJul 20 2015, 4:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MultiSource/
UnitTests/
C++11/
4 lines

Diff 27668

MultiSource/UnitTests/C++11/Makefile

# MultiSource/UnitTests/C++11 Makefile: Build all subdirectories automatically # MultiSource/UnitTests/C++11 Makefile: Build all subdirectories automatically
LEVEL = ../../.. LEVEL = ../../..
PARALLEL_DIRS := frame_layout PARALLEL_DIRS := frame_layout
CPPFLAGS += -std=c++11 CPPFLAGS += -std=c++11
ifdef BENCHMARKING_ONLY ifdef BENCHMARKING_ONLY
PARALLEL_DIRS := $(filter-out frame_layout, $(PARALLEL_DIRS)) PARALLEL_DIRS := $(filter-out frame_layout, $(PARALLEL_DIRS))
endif endif
ifneq (,$(findstring mips16,$(MIPSARCH)))
PARALLEL_DIRS := $(filter-out frame_layout, $(PARALLEL_DIRS))
endif
include $(LEVEL)/Makefile.config include $(LEVEL)/Makefile.config
include $(LEVEL)/Makefile.programs include $(LEVEL)/Makefile.programs