This is an archive of the discontinued LLVM Phabricator instance.

[libc++][ci] Enable modules in the Runtimes build
ClosedPublic

Authored by ldionne on Jun 14 2021, 11:45 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rG1b87573aaf8a: [libc++][ci] Enable modules in the Runtimes build
Summary

The runtimes build has assertions enabled, which is necessary to catch
some of the modules-related issues we've been seeing recently. This
patch enables testing with modules in the runtimes build so as to cover
those cases.

In the future, a better solution would be to systematically use versions
of Clang that have assertions enabled. However, the Clangs we release
currently don't have assertions enabled by default, which causes a
challenge for the CI (we could try to build our own Clang from ToT with
assertions in the CI, but that poses some problems).

Diff Detail

Event Timeline

ldionne created this revision.Jun 14 2021, 11:45 AM
ldionne requested review of this revision.Jun 14 2021, 11:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 11:45 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision as: Restricted Project.Jun 14 2021, 8:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2021, 8:05 PM
This revision was automatically updated to reflect the committed changes.