Page MenuHomePhabricator

[libc++] [test] No longer rely on std::hash<T>::argument_type.
ClosedPublic

Authored by Quuxplusone on Jun 11 2021, 6:03 PM.

Details

Summary

std::hash<T>::argument_type is gone in C++20. De-complicate this code so that it doesn't need to mess around with argument_type (or type traits) anymore.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Jun 11 2021, 6:03 PM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJun 11 2021, 6:03 PM
Quuxplusone added inline comments.Jun 11 2021, 6:04 PM
libcxx/test/std/containers/test_hash.h
13

This is the only file with manual changes. Every other file's changes are simply
s/test_hash<std::hash<.*>>/test_hash<\1>/g.

ldionne accepted this revision.Jun 14 2021, 5:46 AM

Did we have any uses of test_hash with a hash that's not std::hash?

This revision is now accepted and ready to land.Jun 14 2021, 5:46 AM

Did we have any uses of test_hash with a hash that's not std::hash?

No, we did not.