For the moment, TargetMachine::getTargetTriple() still returns a StringRef.
This continues the patch series to eliminate StringRef forms of GNU triples
from the internals of LLVM that began in r239036.
Paths
| Differential D10362
Replace string GNU Triples with llvm::Triple in TargetMachine. NFC. ClosedPublic Authored by dsanders on Jun 10 2015, 9:28 AM.
Details Summary For the moment, TargetMachine::getTargetTriple() still returns a StringRef. This continues the patch series to eliminate StringRef forms of GNU triples
Diff Detail Event TimelineComment Actions Comments inline. Otherwise, LGTM. Thanks!
This revision is now accepted and ready to land.Jun 11 2015, 4:23 AM
Revision Contents
Diff 27449 include/llvm/Support/TargetRegistry.h
include/llvm/Target/TargetMachine.h
lib/CodeGen/LLVMTargetMachine.cpp
lib/Target/AArch64/AArch64TargetMachine.h
lib/Target/AArch64/AArch64TargetMachine.cpp
lib/Target/ARM/ARMTargetMachine.h
lib/Target/ARM/ARMTargetMachine.cpp
lib/Target/BPF/BPFTargetMachine.h
lib/Target/BPF/BPFTargetMachine.cpp
lib/Target/CppBackend/CPPTargetMachine.h
lib/Target/Hexagon/HexagonTargetMachine.h
lib/Target/Hexagon/HexagonTargetMachine.cpp
lib/Target/MSP430/MSP430TargetMachine.h
lib/Target/MSP430/MSP430TargetMachine.cpp
lib/Target/Mips/MipsTargetMachine.h
lib/Target/Mips/MipsTargetMachine.cpp
lib/Target/NVPTX/NVPTXTargetMachine.h
lib/Target/NVPTX/NVPTXTargetMachine.cpp
lib/Target/PowerPC/PPCTargetMachine.h
lib/Target/PowerPC/PPCTargetMachine.cpp
lib/Target/R600/AMDGPUTargetMachine.h
lib/Target/R600/AMDGPUTargetMachine.cpp
lib/Target/Sparc/SparcTargetMachine.h
lib/Target/Sparc/SparcTargetMachine.cpp
lib/Target/SystemZ/SystemZTargetMachine.h
lib/Target/SystemZ/SystemZTargetMachine.cpp
lib/Target/TargetMachine.cpp
lib/Target/X86/X86TargetMachine.h
lib/Target/X86/X86TargetMachine.cpp
lib/Target/XCore/XCoreTargetMachine.h
lib/Target/XCore/XCoreTargetMachine.cpp
|
I'd rename this to getTripleName or something like that, to make sure we don't mix with other get Triples that actually return a triple.
This can be in a different patch, though, maybe with a FIXME comment here now.