This is an archive of the discontinued LLVM Phabricator instance.

Replace string GNU Triples with llvm::Triple in TargetMachine. NFC.
ClosedPublic

Authored by dsanders on Jun 10 2015, 9:28 AM.

Details

Summary

For the moment, TargetMachine::getTargetTriple() still returns a StringRef.

This continues the patch series to eliminate StringRef forms of GNU triples
from the internals of LLVM that began in r239036.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 27449.Jun 10 2015, 9:28 AM
dsanders retitled this revision from to Replace string GNU Triples with llvm::Triple in TargetMachine. NFC..
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added subscribers: rengolin, Unknown Object (MLST).
rengolin accepted this revision.Jun 11 2015, 4:23 AM
rengolin added a reviewer: rengolin.

Comments inline.

Otherwise, LGTM. Thanks!

include/llvm/Target/TargetMachine.h
107

I'd rename this to getTripleName or something like that, to make sure we don't mix with other get Triples that actually return a triple.

This can be in a different patch, though, maybe with a FIXME comment here now.

This revision is now accepted and ready to land.Jun 11 2015, 4:23 AM
dsanders added inline comments.Jun 11 2015, 7:15 AM
include/llvm/Target/TargetMachine.h
107

I'll put a FIXME in for now. D10381 should resolve this since it makes this function return a triple.

dsanders closed this revision.Jun 11 2015, 12:45 PM