This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix the include_as_c.sh.cpp test in MSVC configurations
ClosedPublic

Authored by mstorsjo on May 31 2021, 4:23 AM.

Details

Summary

Avoid including a header that is known not to work with clang in MSVC
mode when compiling as C.

(Alternatively, this could be something like "XFAIL: clang && msvc",
but I think it's more useful to actually check the rest of the test
instead of expecting the whole test to fail.)

Diff Detail

Event Timeline

mstorsjo requested review of this revision.May 31 2021, 4:23 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2021, 4:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 31 2021, 7:44 AM
This revision is now accepted and ready to land.May 31 2021, 7:44 AM
This revision was landed with ongoing or failed builds.May 31 2021, 12:13 PM
This revision was automatically updated to reflect the committed changes.