[lldbtest] Use netloc instead of hostname to look up Android device ID.

[sivachandra]

Summary

urlparse.ParseResult.hostname has only lowercase characters even if the
input URL had uppercase characters. Since Android device IDs can have
uppercase characters as well, use urlparse.ParseResult.netloc instead
and extract the device ID from it.

This change also improves the error message when lookup of the Android
device's API fails.

[chaoren]

test/lldbtest.py

443

lldb.platform_url.startswith?

444

I would prefer if we delegated as much parsing as possible to urlparse.
We can check parsed.scheme and use parsed.netloc.split(':')[0] as hostname.

[chaoren]

test/lldbtest.py

448

I don't think it's possible to not have a platform url here. Return false if not lldb.platform_url?

[sivachandra]

Address comments.

[chaoren]

LGTM

test/lldbtest.py

 import time
 import types
 import unittest2
 import lldb
 import lldbtest_config
 import lldbutil
 from _pyio import __metaclass__
 
-if sys.version_info.major < 3:
-    import urlparse
-else:
-    import urllib.parse as urlparse
-
 # dosep.py starts lots and lots of dotest instances
 # This option helps you find if two (or more) dotest instances are using the same
 # directory at the same time
 # Enable it to cause test failures and stderr messages if dotest instances try to run in
 # the same directory simultaneously
 # it is disabled by default because it litters the test directories with ".dirlock" files
 debug_confirm_directory_exclusivity = False
 
if device_id:
         device_id_args = ["-s", device_id]
     full_cmd = ["adb"] + device_id_args + cmd
     p = Popen(full_cmd, stdout=PIPE, stderr=PIPE)
     stdout, stderr = p.communicate()
     return p.returncode, stdout, stderr
 
 def android_device_api():
     device_id = None
-    if lldb.platform_url:
-        parsed = urlparse.urlparse(lldb.platform_url)
-        if parsed.scheme == "adb":
-            device_id = parsed.hostname
+    if lldb.platform_url and lldb.platform_url[:6] == "adb://":
+        device_id = lldb.platform_url.split(":")[1][2:]
     retcode, stdout, stderr = run_adb_command(
         ["shell", "getprop", "ro.build.version.sdk"], device_id)
     if retcode == 0:
         return int(stdout)
     else:
         raise LookupError(
-            "Unable to determine the API level of the Android device.")
+            ">>> Unable to determine the API level of the Android device.\n"
+            ">>> stdout:\n%s\n"
+            ">>> stderr:\n%s\n" % (stdout, stderr))
 
 #
 # Decorators for categorizing test cases.
 #
 
 from functools import wraps
 def python_api_test(func):
     """Decorate the item as a Python API only test."""