This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Make the visibility attributes consistent for __narrow_to_utf8/__widen_from_utf8
ClosedPublic

Authored by mstorsjo on May 18 2021, 1:07 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG3a6be27978aa: [libcxx] Make the visibility attributes consistent for…
Summary

Use the same visiblity attributes as for all other template
specializations in the same file; declare the specialization itself
using _LIBCPP_TYPE_VIS, and don't use _LIBCPP_EXPORTED_FROM_ABI on
the destructor. Methods that are excluded from the ABI are marked
with _LIBCPP_INLINE_VISIBILITY.

This makes the vtable exported from DLL builds of libc++. Practically,
it doesn't make any difference for the CI configuration, but it
can make a difference in mingw setups.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.May 18 2021, 1:07 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2021, 1:07 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 25 2021, 12:28 PM
This revision is now accepted and ready to land.May 25 2021, 12:28 PM