This is an archive of the discontinued LLVM Phabricator instance.

Differential D102354

[libcxx] NFC. Fix misprint unodered -> unordered
ClosedPublic

Authored by krisb on May 12 2021, 12:39 PM.

Details

Reviewers
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rG8a86787847d9: [libcxx] NFC. Fix misprint unodered -> unordered

Diff Detail

Event Timeline

krisb requested review of this revision.May 12 2021, 12:39 PM
krisb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2021, 12:39 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
• Quuxplusone accepted this revision as: • Quuxplusone.May 12 2021, 12:44 PM
• Quuxplusone added inline comments.
libcxx/include/__hash_table
2512–2514

Maybe even eliminate the second repetition of "unordered" here: just say "...an iterator not referring to this container". No big deal either way.

Harbormaster completed remote builds in B104110: Diff 344915.May 12 2021, 2:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 13 2021, 12:58 AM
Closed by commit rG8a86787847d9: [libcxx] NFC. Fix misprint unodered -> unordered (authored by krisb). · Explain Why
This revision was automatically updated to reflect the committed changes.
krisb added a commit: rG8a86787847d9: [libcxx] NFC. Fix misprint unodered -> unordered.

Revision Contents

PathSize
libcxx/
include/
8 lines

Diff 345065

libcxx/include/__hash_table

Show First 20 Lines • Show All 2,500 Lines • ▼ Show 20 Lines
template <class _Tp, class _Hash, class _Equal, class _Alloc> template <class _Tp, class _Hash, class _Equal, class _Alloc>
typename __hash_table<_Tp, _Hash, _Equal, _Alloc>::iterator typename __hash_table<_Tp, _Hash, _Equal, _Alloc>::iterator
__hash_table<_Tp, _Hash, _Equal, _Alloc>::erase(const_iterator __first, __hash_table<_Tp, _Hash, _Equal, _Alloc>::erase(const_iterator __first,
const_iterator __last) const_iterator __last)
{ {
#if _LIBCPP_DEBUG_LEVEL == 2 #if _LIBCPP_DEBUG_LEVEL == 2
_LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(&__first) == this, _LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(&__first) == this,
"unodered container::erase(iterator, iterator) called with an iterator not" "unordered container::erase(iterator, iterator) called with an iterator not"
" referring to this unodered container"); " referring to this container");
_LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(&__last) == this, _LIBCPP_ASSERT(__get_const_db()->__find_c_from_i(&__last) == this,
"unodered container::erase(iterator, iterator) called with an iterator not" "unordered container::erase(iterator, iterator) called with an iterator not"
" referring to this unodered container"); " referring to this container");
#endif #endif
QuuxplusoneUnsubmitted
Not Done
ReplyInline Actions

Maybe even eliminate the second repetition of "unordered" here: just say "...an iterator not referring to this container". No big deal either way.

Quuxplusone: Maybe even eliminate the second repetition of "unordered" here: just say "...an iterator not…
for (const_iterator __p = __first; __first != __last; __p = __first) for (const_iterator __p = __first; __first != __last; __p = __first)
{ {
++__first; ++__first;
erase(__p); erase(__p);
} }
__next_pointer __np = __last.__node_; __next_pointer __np = __last.__node_;
#if _LIBCPP_DEBUG_LEVEL == 2 #if _LIBCPP_DEBUG_LEVEL == 2
return iterator (__np, this); return iterator (__np, this);
▲ Show 20 Lines • Show All 291 Lines • Show Last 20 Lines