This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Add an assert regarding the RVA of exported symbols. NFC.
ClosedPublic

Authored by mstorsjo on May 8 2021, 2:05 PM.

Details

Summary

As this isn't handled as a regular relocation, the normal handling of
maybeReportRelocationToDiscarded in Chunks.cpp doesn't apply here.

This would have caught the issue fixed by
82de4e075339f5ad8d68cfe31eb45b771d4750ae.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.May 8 2021, 2:05 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2021, 2:05 PM
rnk accepted this revision.May 10 2021, 5:35 PM

lgtm

This revision is now accepted and ready to land.May 10 2021, 5:35 PM