This is an archive of the discontinued LLVM Phabricator instance.

Differential D10193

[CMake] Add warning for using compile and link pools on unsupported versions of CMake or non-ninja generators.
ClosedPublic

Authored by beanz on Jun 2 2015, 11:55 AM.

Details

Reviewers
eugenis
Commits
rG762cbe701804: [CMake] Add warning for using compile and link pools on unsupported versions of…
rL239044: [CMake] Add warning for using compile and link pools on unsupported versions of…
Summary

I've gotten feedback from users on CMake 2.8 that the compile and link pool options were not working. This is expected so I'm adding a warning so we can report invalid configurations to users.

Diff Detail

Event Timeline

beanz updated this revision to Diff 26996.Jun 2 2015, 11:55 AM
beanz retitled this revision from to [CMake] Add warning for using compile and link pools on unsupported versions of CMake or non-ninja generators..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: eugenis.
beanz added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Jun 3 2015, 4:55 PM
eugenis edited edge metadata.

LGTM, thanks

This revision is now accepted and ready to land.Jun 3 2015, 4:55 PM
Closed by commit rL239044: [CMake] Add warning for using compile and link pools on unsupported versions of… (authored by cbieneman). · Explain WhyJun 4 2015, 8:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
16 lines

Diff 26996

CMakeLists.txt

Show All 26 Lines
endif() endif()
project(LLVM) project(LLVM)
# The following only works with the Ninja generator in CMake >= 3.0. # The following only works with the Ninja generator in CMake >= 3.0.
set(LLVM_PARALLEL_COMPILE_JOBS "" CACHE STRING set(LLVM_PARALLEL_COMPILE_JOBS "" CACHE STRING
"Define the maximum number of concurrent compilation jobs.") "Define the maximum number of concurrent compilation jobs.")
if(LLVM_PARALLEL_COMPILE_JOBS) if(LLVM_PARALLEL_COMPILE_JOBS)
if(CMAKE_VERSION VERSION_LESS 3.0 OR NOT CMAKE_MAKE_PROGRAM STREQUAL "ninja")
message(WARNING "Job pooling is only available with Ninja generators and CMake 3.0 and later.")
else()
set_property(GLOBAL APPEND PROPERTY JOB_POOLS compile_job_pool=${LLVM_PARALLEL_COMPILE_JOBS}) set_property(GLOBAL APPEND PROPERTY JOB_POOLS compile_job_pool=${LLVM_PARALLEL_COMPILE_JOBS})
set(CMAKE_JOB_POOL_COMPILE compile_job_pool) set(CMAKE_JOB_POOL_COMPILE compile_job_pool)
endif() endif()
endif()
set(LLVM_PARALLEL_LINK_JOBS "" CACHE STRING set(LLVM_PARALLEL_LINK_JOBS "" CACHE STRING
"Define the maximum number of concurrent link jobs.") "Define the maximum number of concurrent link jobs.")
if(LLVM_PARALLEL_LINK_JOBS) if(LLVM_PARALLEL_LINK_JOBS)
if(CMAKE_VERSION VERSION_LESS 3.0 OR NOT CMAKE_MAKE_PROGRAM STREQUAL "ninja")
message(WARNING "Job pooling is only available with Ninja generators and CMake 3.0 and later.")
else()
set_property(GLOBAL APPEND PROPERTY JOB_POOLS link_job_pool=${LLVM_PARALLEL_LINK_JOBS}) set_property(GLOBAL APPEND PROPERTY JOB_POOLS link_job_pool=${LLVM_PARALLEL_LINK_JOBS})
set(CMAKE_JOB_POOL_LINK link_job_pool) set(CMAKE_JOB_POOL_LINK link_job_pool)
endif() endif()
endif()
# Add path for custom modules # Add path for custom modules
set(CMAKE_MODULE_PATH set(CMAKE_MODULE_PATH
${CMAKE_MODULE_PATH} ${CMAKE_MODULE_PATH}
"${CMAKE_CURRENT_SOURCE_DIR}/cmake" "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
) )
▲ Show 20 Lines • Show All 624 Lines • Show Last 20 Lines