This is an archive of the discontinued LLVM Phabricator instance.

Differential D10123

TestHandleSegv: also assert that we have a thread
ClosedPublic

Authored by emaste on May 29 2015, 7:56 AM.

Details

Reviewers
labath
Commits
rG36cbc0901f7a: TestHandleSegv: also assert that we have a thread
rLLDB238600: TestHandleSegv: also assert that we have a thread
rL238600: TestHandleSegv: also assert that we have a thread
Summary

If get_stopped_thread(... eStopReasonSignal) returns no thread, the thread.IsValid assertion would throw AttributeError: 'NoneType' object has no attribute 'IsValid'.

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 26782.May 29 2015, 7:56 AM
emaste retitled this revision from to TestHandleSegv: also assert that we have a thread.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: labath.
emaste added a subscriber: Unknown Object (MLST).
labath accepted this revision.May 29 2015, 9:23 AM
labath edited edge metadata.

lgtm

This revision is now accepted and ready to land.May 29 2015, 9:23 AM
Closed by commit rL238600: TestHandleSegv: also assert that we have a thread (authored by emaste). · Explain WhyMay 29 2015, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
test/
functionalities/
signal/
handle-segv/
2 lines

Diff 26812

lldb/trunk/test/functionalities/signal/handle-segv/TestHandleSegv.py

Show All 23 Lines def test_inferior_handle_sigsegv_with_dwarf(self):
# launch # launch
process = target.LaunchSimple(None, None, self.get_process_working_directory()) process = target.LaunchSimple(None, None, self.get_process_working_directory())
self.assertTrue(process, PROCESS_IS_VALID) self.assertTrue(process, PROCESS_IS_VALID)
self.assertEqual(process.GetState(), lldb.eStateStopped) self.assertEqual(process.GetState(), lldb.eStateStopped)
signo = process.GetUnixSignals().GetSignalNumberFromName("SIGSEGV") signo = process.GetUnixSignals().GetSignalNumberFromName("SIGSEGV")
thread = lldbutil.get_stopped_thread(process, lldb.eStopReasonSignal) thread = lldbutil.get_stopped_thread(process, lldb.eStopReasonSignal)
self.assertTrue(thread.IsValid(), "Thread should be stopped due to a signal") self.assertTrue(thread and thread.IsValid(), "Thread should be stopped due to a signal")
self.assertTrue(thread.GetStopReasonDataCount() >= 1, "There was data in the event.") self.assertTrue(thread.GetStopReasonDataCount() >= 1, "There was data in the event.")
self.assertEqual(thread.GetStopReasonDataAtIndex(0), signo, "The stop signal was SIGSEGV") self.assertEqual(thread.GetStopReasonDataAtIndex(0), signo, "The stop signal was SIGSEGV")
# Continue until we exit. # Continue until we exit.
process.Continue() process.Continue()
self.assertEqual(process.GetState(), lldb.eStateExited) self.assertEqual(process.GetState(), lldb.eStateExited)
self.assertEqual(process.GetExitStatus(), 0) self.assertEqual(process.GetExitStatus(), 0)
if __name__ == '__main__': if __name__ == '__main__':
import atexit import atexit
lldb.SBDebugger.Initialize() lldb.SBDebugger.Initialize()
atexit.register(lambda: lldb.SBDebugger.Terminate()) atexit.register(lambda: lldb.SBDebugger.Terminate())
unittest2.main() unittest2.main()