This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] slightly improve weak-private-extern.s test
ClosedPublic

Authored by thakis on Apr 22 2021, 7:00 AM.

Reviewers

int3

Group Reviewers

Restricted Project

Commits

Summary

__got is in --bind output, so print that too (makes the test a bit stronger)
WEAK_DEFINES, BINDS_TO_WEAK are in the mach-o header, so --private-header is enough, no need for --all-headers (makes the test a bit easier to work with when it fails)

thakis requested review of this revision.Apr 22 2021, 7:00 AM

lgtm

This revision is now accepted and ready to land.Apr 22 2021, 1:49 PM

This revision was landed with ongoing or failed builds.Apr 22 2021, 7:43 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

test/

MachO/

4 lines

	# REQUIRES: x86			# REQUIRES: x86

	# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.o			# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.o
	# RUN: %lld -dylib %t.o -o %t.dylib -lSystem			# RUN: %lld -dylib %t.o -o %t.dylib -lSystem

	# RUN: llvm-objdump --macho --weak-bind %t.dylib \| FileCheck %s			# RUN: llvm-objdump --macho --bind --weak-bind %t.dylib \| FileCheck %s
	# CHECK-NOT: __got			# CHECK-NOT: __got
	# CHECK-NOT: __la_symbol_ptr			# CHECK-NOT: __la_symbol_ptr

	# RUN: llvm-objdump --macho --all-headers %t.dylib \| \			# RUN: llvm-objdump --macho --private-header %t.dylib \| \
	# RUN: FileCheck --check-prefix=HEADERS %s			# RUN: FileCheck --check-prefix=HEADERS %s
	# HEADERS-NOT: WEAK_DEFINES			# HEADERS-NOT: WEAK_DEFINES
	# HEADERS-NOT: BINDS_TO_WEAK			# HEADERS-NOT: BINDS_TO_WEAK

	## Check that N_WEAK_DEF isn't set in the symbol table.			## Check that N_WEAK_DEF isn't set in the symbol table.
	## This is different from ld64, which makes private extern weak symbols non-weak			## This is different from ld64, which makes private extern weak symbols non-weak
	## for binds and relocations, but it still marks them as weak in the symbol table.			## for binds and relocations, but it still marks them as weak in the symbol table.
	## Since `nm -m` doesn't look at N_WEAK_DEF for N_PEXT symbols this is not			## Since `nm -m` doesn't look at N_WEAK_DEF for N_PEXT symbols this is not
	Show All 22 Lines