Page MenuHomePhabricator

Refactoring cl::list_storage from "is a" to "has a" std::vector.
ClosedPublic

Authored by beanz on May 28 2015, 10:00 AM.

Details

Summary

This isn't necessarily an ideal change, and I want to at least reduce the API surface area, but for the new API we really shouldn't be relying on cl::list being a std::vector.

Diff Detail

Event Timeline

beanz updated this revision to Diff 26696.May 28 2015, 10:00 AM
beanz retitled this revision from to Refactoring cl::list_storage from "is a" to "has a" std::vector..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: chandlerc.
beanz added a subscriber: Unknown Object (MLST).
chandlerc accepted this revision.May 28 2015, 1:23 PM
chandlerc edited edge metadata.

Yuck. But I agree with you completely. I can't bring myself to say this "looks good" but it looks *right*. Go for it.

include/llvm/Support/CommandLine.h
1291

Add a FIXME comment to indicate that we want to reduce this over time to a reasonably narrow API?

This revision is now accepted and ready to land.May 28 2015, 1:23 PM
This revision was automatically updated to reflect the committed changes.