Page MenuHomePhabricator

Move inlined cxa_demangle.cpp to a separate file.
ClosedPublic

Authored by chaoren on May 22 2015, 3:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren retitled this revision from to Move inlined cxa_demangle.cpp to a separate file..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: clayborg, emaste, zturner.
chaoren added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.May 22 2015, 3:28 PM

Is the inlining actually necessary? Why not just have cxx_demangle.h which exposes __cxa_demangle, and put all the implementations in in cxx_demangle.cpp?

clayborg requested changes to this revision.May 26 2015, 3:18 PM
clayborg edited edge metadata.

If you are going to move it into a separate file, you will need to put it in the lldb_private namespace as opposed to the anonymous namespace, and please put it into a separate source file with a .cpp extension not .inc and just call the function. You will need a header file as well for the source file. We might want one for the inlined libc++abi demangler and one for the demangler that Kate Stone added (if it isn't already in a separate file).

This revision now requires changes to proceed.May 26 2015, 3:18 PM
chaoren edited edge metadata.

Move to .cpp instead of .inc. Added .h files (for FastDemangle as well).

clayborg accepted this revision.May 26 2015, 5:07 PM
clayborg edited edge metadata.

Much better.

This revision is now accepted and ready to land.May 26 2015, 5:07 PM
This revision was automatically updated to reflect the committed changes.