In preparation for some changes to make this compatible with MSVC.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Is the inlining actually necessary? Why not just have cxx_demangle.h which exposes __cxa_demangle, and put all the implementations in in cxx_demangle.cpp?
Comment Actions
If you are going to move it into a separate file, you will need to put it in the lldb_private namespace as opposed to the anonymous namespace, and please put it into a separate source file with a .cpp extension not .inc and just call the function. You will need a header file as well for the source file. We might want one for the inlined libc++abi demangler and one for the demangler that Kate Stone added (if it isn't already in a separate file).