Page MenuHomePhabricator

[RS4GC] Cleanup meetBDVState. NFC.
ClosedPublic

Authored by skatkov on Mon, Mar 22, 3:18 AM.

Details

Summary

meetBDVState looks pretty difficult to read and follow.
This is purely NFC but doing several things:

  1. Combine meet and meetBDVState
  2. move the function under member of BDVState
  3. Make BDVState be a mutable object.
  4. Convert switch to sequence of ifs
  5. Adds comments.

The patch is published to get a feedback whether this change simplifies the reading of the method.
If it is not, I'm fine to abandon it.

Diff Detail

Event Timeline

skatkov created this revision.Mon, Mar 22, 3:18 AM
skatkov requested review of this revision.Mon, Mar 22, 3:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 22, 3:18 AM
reames accepted this revision.Thu, Apr 8, 1:28 PM

LGTM

This basically reverts a couple of my recent changes, but I think I agree that the seperation I was trying for didn't work out well. Thanks for doing this.

This revision is now accepted and ready to land.Thu, Apr 8, 1:28 PM
This revision was landed with ongoing or failed builds.Thu, Apr 8, 9:18 PM
This revision was automatically updated to reflect the committed changes.