This is an archive of the discontinued LLVM Phabricator instance.

[M68k] Make M68k TargetMachine use getter function
ClosedPublic

Authored by ricky26 on Mar 12 2021, 8:46 AM.

Details

Summary

This makes M68k match other platforms in this regard.

This was done as part of the AsmParser/Disassembler work since the entry functions of those modules usually reference getTheXXXTarget().

Diff Detail

Event Timeline

ricky26 created this revision.Mar 12 2021, 8:46 AM
ricky26 edited the summary of this revision. (Show Details)Mar 12 2021, 8:59 AM
ricky26 edited the summary of this revision. (Show Details)
ricky26 published this revision for review.Mar 12 2021, 9:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 9:07 AM
ricky26 updated this revision to Diff 330279.Mar 12 2021, 9:36 AM

Appease clang-tidy

RKSimon added a subscriber: RKSimon.
RKSimon added inline comments.
llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
15

Interestingly X86MCTargetDesc.cpp doesn't need the "../" - are we missing an include path somewhere?

ricky26 updated this revision to Diff 330360.Mar 12 2021, 1:35 PM

Remove unecessary ../ from include

ricky26 marked an inline comment as done.Mar 12 2021, 1:37 PM
ricky26 added inline comments.
llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp
15

It looks like I'd done that myself unnecessarily. It compiles without the "../".

ricky26 marked an inline comment as done.Mar 12 2021, 5:50 PM
RKSimon accepted this revision.Mar 13 2021, 4:06 AM

LGTM - cheers

This revision is now accepted and ready to land.Mar 13 2021, 4:06 AM
myhsu accepted this revision.Mar 14 2021, 11:40 AM

LGTM, thanks

This revision was landed with ongoing or failed builds.Mar 14 2021, 11:54 AM
This revision was automatically updated to reflect the committed changes.