This is an archive of the discontinued LLVM Phabricator instance.

libcxx: Fix ARM libc++/abi and libunwind buildbot.
ClosedPublic

Authored by logan on May 16 2015, 5:25 AM.

Details

Summary

The test cases were crashing due to the mixed usage of the unwinding
functions from both libunwind and libgcc_s. The unwind functions are
mixed because the "llvm_unwinder" entry is not available in the
lit.site.cfg for libc++. As a result, "-lgcc_s" is picked instead of
"-lunwind". The extra option to lit --param=link_flags="-lunwind" won't
help either.

This CL fix the problem by adding llvm_unwinder to lit.site.cfg.in.

Diff Detail

Event Timeline

logan updated this revision to Diff 25917.May 16 2015, 5:25 AM
logan retitled this revision from to libcxx: Fix ARM libc++/abi and libunwind buildbot..
logan updated this object.
logan edited the test plan for this revision. (Show Details)
logan added reviewers: rengolin, danalbert, compnerd.
logan added a subscriber: Unknown Object (MLST).
rengolin accepted this revision.May 16 2015, 5:38 AM
rengolin edited edge metadata.

YAY! If that fixes the bots, and continue testing what it was supposed to test (libcxxabi+libunwind), I'm happy. :)

This revision is now accepted and ready to land.May 16 2015, 5:38 AM
logan closed this revision.May 16 2015, 5:48 AM

Thanks for your review. Committed as rL237518.

Let's see if it works.