Page MenuHomePhabricator

[MSan][RISCV] Add RISCV64 support for MSan
Needs ReviewPublic

Authored by luismarques on Mar 3 2021, 5:24 PM.

Details

Summary

RISCV64 support for ASan and LSan has been merged. This patch adds further support for MSan. There are no known issues (besides those indicated by the test changes).

Diff Detail

Event Timeline

luismarques created this revision.Mar 3 2021, 5:24 PM
luismarques requested review of this revision.Mar 3 2021, 5:24 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 3 2021, 5:24 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
luismarques edited the summary of this revision. (Show Details)
  • Add VarArg handling.
  • Adjust tests.
MaskRay added inline comments.
compiler-rt/test/msan/mmap.cpp
30

(__riscv_xlen == 64) -> __riscv_xlen == 64

69

ditto

compiler-rt/test/msan/mmap_below_shadow.cpp
36

ditto

compiler-rt/test/msan/param_tls_limit.cpp
23

If you expect riscv32 will fail as well, use riscv

Address review feedback (thanks @MaskRay!).

luismarques marked 4 inline comments as done.Tue, Mar 30, 1:12 PM
luismarques edited the summary of this revision. (Show Details)

Optimize address mappings.

luismarques retitled this revision from [MSan][RISCV][Draft] Draft implementation of MSan RISC-V support to [MSan][RISCV] Add RISC-V support for MSan.Wed, Apr 7, 3:23 AM
luismarques edited the summary of this revision. (Show Details)
luismarques added reviewers: eugenis, asb, kcc, MaskRay.
luismarques retitled this revision from [MSan][RISCV] Add RISC-V support for MSan to [MSan][RISCV] Add RISCV64 support for MSan.Wed, Apr 7, 6:27 AM