[MSan][RISCV] Add RISCV64 support for MSan
Needs ReviewPublic
Actions

Authored by luismarques on Mar 3 2021, 5:24 PM.

Details

Reviewers

eugenis
asb
kcc
MaskRay

Summary

RISCV64 support for ASan and LSan has been merged. This patch adds further support for MSan. There are no known issues (besides those indicated by the test changes).

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

luismarques created this revision.Mar 3 2021, 5:24 PM

Herald added subscribers: vkmr, evandro, sameer.abuasal and 11 others. · View Herald TranscriptMar 3 2021, 5:24 PM

luismarques requested review of this revision.Mar 3 2021, 5:24 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 3 2021, 5:24 PM

Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript

luismarques added a parent revision: D97896: [Clang][RISCV][RFC] Add byval parameter attribute?.Mar 3 2021, 5:25 PM

Harbormaster completed remote builds in B91936: Diff 327970.Mar 4 2021, 3:44 AM

Add VarArg handling.
Adjust tests.

Harbormaster completed remote builds in B96333: Diff 334172.Tue, Mar 30, 9:31 AM

MaskRay added a subscriber: MaskRay.Tue, Mar 30, 10:37 AM

MaskRay added inline comments.

compiler-rt/test/msan/mmap.cpp
30	`(__riscv_xlen == 64) -> __riscv_xlen == 64`
69	ditto
compiler-rt/test/msan/mmap_below_shadow.cpp
36	ditto
compiler-rt/test/msan/param_tls_limit.cpp
23	If you expect riscv32 will fail as well, use `riscv`

Address review feedback (thanks @MaskRay!).

luismarques marked 4 inline comments as done.Tue, Mar 30, 1:12 PM

Harbormaster completed remote builds in B96391: Diff 334255.Tue, Mar 30, 1:50 PM

luismarques removed a parent revision: D97896: [Clang][RISCV][RFC] Add byval parameter attribute?.Wed, Mar 31, 9:28 AM

Optimize address mappings.

luismarques retitled this revision from [MSan][RISCV][Draft] Draft implementation of MSan RISC-V support to [MSan][RISCV] Add RISC-V support for MSan.Wed, Apr 7, 3:23 AM

luismarques edited the summary of this revision. (Show Details)

luismarques added reviewers: eugenis, asb, kcc, MaskRay.

Harbormaster completed remote builds in B97485: Diff 335769.Wed, Apr 7, 3:47 AM

luismarques retitled this revision from [MSan][RISCV] Add RISC-V support for MSan to [MSan][RISCV] Add RISCV64 support for MSan.Wed, Apr 7, 6:27 AM