Page MenuHomePhabricator
Differential D94859

[ValueTracking] Make impliesPoison look into operands of V
AbandonedPublic
Actions

Authored by aqjune on Jan 16 2021, 1:29 AM.

Details

Reviewers
nikic
spatel
lebedev.ri
Summary

This patch updates impliesPoison to look into operands of V up to MaxDepth.

Relevant patch: D94550

Diff Detail

Event Timeline

aqjune created this revision.Jan 16 2021, 1:29 AM
Herald added subscribers: dexonsmith, hiraditya. · View Herald TranscriptJan 16 2021, 1:29 AM
aqjune requested review of this revision.Jan 16 2021, 1:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2021, 1:29 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aqjune added a comment.Jan 16 2021, 1:30 AM

I'll leave the diff result after setting -instcombine-unsafe-select-transform=0 at another patch that's going to follow this.

Harbormaster completed remote builds in B85485: Diff 317160.Jan 16 2021, 2:02 AM
aqjune mentioned this in D94861: [InstCombine,InstSimplify] Optimize select followed by and/or/xor.Jan 16 2021, 3:43 AM
nikic mentioned this in D94866: [ValueTracking] Strengthen impliesPoison reasoning.Jan 16 2021, 8:24 AM
nikic added a comment.Jan 16 2021, 8:27 AM

I posted an alternative patch at D94866. It's potentially more expensive, but I think it will cover more of the cases we need.

nikic mentioned this in rG051ec9f5f43a: [ValueTracking] Strengthen impliesPoison reasoning.Jan 19 2021, 9:04 AM
aqjune abandoned this revision.Jan 19 2021, 8:19 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
IR/
9 lines
lib/
Analysis/
43 lines
unittests/
Analysis/
20 lines

Diff 317160

View Options

llvm/include/llvm/IR/PatternMatch.h

Loading...
View Options

llvm/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/unittests/Analysis/ValueTrackingTest.cpp

Loading...