This is an archive of the discontinued LLVM Phabricator instance.

[clang][cli] Implement `getAllArgValues` marshalling
ClosedPublic

Authored by jansvoboda11 on Dec 21 2020, 5:30 AM.

Details

Summary

This infrastructure can be used ~30 more command line options.

Diff Detail

Unit TestsFailed

Event Timeline

jansvoboda11 created this revision.Dec 21 2020, 5:30 AM
jansvoboda11 requested review of this revision.Dec 21 2020, 5:30 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 21 2020, 5:30 AM
dexonsmith accepted this revision.Dec 21 2020, 12:53 PM

LGTM.

clang/lib/Frontend/CompilerInvocation.cpp
338

Nit: we usually put the & next to the variable name.

This revision is now accepted and ready to land.Dec 21 2020, 12:53 PM
This revision was landed with ongoing or failed builds.Dec 22 2020, 5:24 AM
This revision was automatically updated to reflect the committed changes.