Page MenuHomePhabricator

Don't setup inalloca for swiftcc on i686-windows-msvc
ClosedPublic

Authored by rnk on Dec 9 2020, 9:26 AM.

Details

Summary

Swiftcall does it's own target-independent argument type classification,
since it is not designed to be ABI compatible with anything local on the
target that isn't LLVM-based. This means it never uses inalloca.
However, we have duplicate logic for checking for inalloca parameters
that runs before call argument setup. This logic needs to know ahead of
time if inalloca will be used later, and we can't move the
CGFunctionInfo calculation earlier.

This change gets the calling convention from either the
FunctionProtoType or ObjCMethodDecl, checks if it is swift, and if so
skips the stackbase setup.

Depends on D92883.

Diff Detail

Event Timeline

rnk requested review of this revision.Dec 9 2020, 9:26 AM
rnk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 9:26 AM
compnerd accepted this revision.Dec 9 2020, 10:57 AM
This revision is now accepted and ready to land.Dec 9 2020, 10:57 AM
This revision was landed with ongoing or failed builds.Dec 9 2020, 11:12 AM
This revision was automatically updated to reflect the committed changes.