Page MenuHomePhabricator

[mac/lld] Implement -t
ClosedPublic

Authored by thakis on Dec 3 2020, 10:06 AM.

Details

Reviewers
compnerd
Group Reviewers
Restricted Project
Commits
rG7cb0a373d1d7: [mac/lld] Implement -t
Summary

Goes well with -why_load to get an idea of load order.

Diff Detail

Event Timeline

thakis created this revision.Dec 3 2020, 10:06 AM
thakis requested review of this revision.Dec 3 2020, 10:06 AM
thakis retitled this revision from [mac/lld] Implement -t option to [mac/lld] Implement -t.Dec 3 2020, 10:09 AM
compnerd accepted this revision.Dec 3 2020, 12:57 PM
compnerd added a subscriber: compnerd.

Seems fine to me. Does the output match what ld64 does?

This revision is now accepted and ready to land.Dec 3 2020, 12:57 PM

Seems fine to me. Does the output match what ld64 does?

Yes. (Unless you use both -t and -why_load -- then we interleave while ld64 does all -t output before all -why_load output.)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 1:03 PM

Seems fine to me. Does the output match what ld64 does?

Yes. (Unless you use both -t and -why_load -- then we interleave while ld64 does all -t output before all -why_load output.)

Oh, and for .a files we only show the basename, while ld64 prints the full path to the .a (but only the basename of the .o therein). Maybe we should change all LLDs to show the full path to the .a, that feels like it'd be generally a good change.