Page MenuHomePhabricator

[GlobalISel] Remove duplicates from possible mappings
Needs ReviewPublic

Authored by ehjogab on Nov 26 2020, 2:15 AM.

Details

Summary

Some targets will in getInstrAlternativeMappings() will return a list
that contains the mapping returned by getInstrMapping(), thereby causing
duplicates. This patch removes such duplicates, which reduces the amount
of work that needs to be done when selecting register banks.

Diff Detail

Unit TestsFailed

TimeTest
380 msx64 debian > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
30 msx64 windows > Clangd Unit Tests._/ClangdTests_exe::ConfigCompileTests.ExternalBlockDisablesBackgroundIndex
Note: Google Test filter = ConfigCompileTests.ExternalBlockDisablesBackgroundIndex [==========] Running 1 test from 1 test case.
20 msx64 windows > Clangd Unit Tests._/ClangdTests_exe::ConfigCompileTests.ExternalBlockMountPoint
Note: Google Test filter = ConfigCompileTests.ExternalBlockMountPoint [==========] Running 1 test from 1 test case.

Event Timeline

ehjogab created this revision.Nov 26 2020, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2020, 2:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
ehjogab requested review of this revision.Nov 26 2020, 2:15 AM
ehjogab updated this revision to Diff 307801.Nov 26 2020, 2:27 AM

Reduce number of necessary checks.