Page MenuHomePhabricator

[Syntax] Tablegen literal expressions.
ClosedPublic

Authored by sammccall on Nov 11 2020, 9:27 AM.

Details

Summary

Non-mechanical changes:

  • Added FIXME to StringLiteral to cover multi-token string literals.
  • LiteralExpression::getLiteralToken() is gone. (It was never called) This is because we don't codegen methods in Alternatives It's conceptually suspect if we consider multi-token string literals, though.

Diff Detail

Event Timeline

sammccall created this revision.Nov 11 2020, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2020, 9:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall requested review of this revision.Nov 11 2020, 9:27 AM
gribozavr2 accepted this revision.Nov 11 2020, 10:17 AM
This revision is now accepted and ready to land.Nov 11 2020, 10:17 AM
eduucaldas accepted this revision.Nov 11 2020, 10:22 AM
This revision was landed with ongoing or failed builds.Nov 11 2020, 4:27 PM
This revision was automatically updated to reflect the committed changes.