Page MenuHomePhabricator

eduucaldas (Eduardo Caldas)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2020, 1:33 AM (33 w, 6 d)

Recent Activity

Nov 11 2020

eduucaldas accepted D91277: [Syntax] Tablegen literal expressions..
Nov 11 2020, 10:22 AM · Restricted Project

Nov 5 2020

eduucaldas committed rG23657d9cc332: [SyntaxTree] Add reverse links to syntax Nodes. (authored by eduucaldas).
[SyntaxTree] Add reverse links to syntax Nodes.
Nov 5 2020, 1:54 AM
eduucaldas closed D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Nov 5 2020, 1:54 AM · Restricted Project

Nov 4 2020

eduucaldas added a comment to D90240: [SyntaxTree] Add reverse links to syntax Nodes..

As we discussed offline we will probably not provide replaceChildRange in the public mutations API anymore.

Nov 4 2020, 9:56 AM · Restricted Project
eduucaldas updated the diff for D90240: [SyntaxTree] Add reverse links to syntax Nodes..

Rebase

Nov 4 2020, 9:56 AM · Restricted Project
eduucaldas added a comment to D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC.

Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy and
less like a grammar. (E.g. variants list the Alternatives parent rather than
vice versa).

Nov 4 2020, 9:25 AM · Restricted Project
eduucaldas accepted D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC.
Nov 4 2020, 2:55 AM · Restricted Project
eduucaldas accepted D90662: [Syntax] Tablegen operator<<(NodeKind). NFC.
Nov 4 2020, 2:47 AM · Restricted Project
eduucaldas updated subscribers of D90662: [Syntax] Tablegen operator<<(NodeKind). NFC.
Nov 4 2020, 1:04 AM · Restricted Project

Nov 1 2020

eduucaldas accepted D90541: [Syntax] DeclaratorList is a List.
Nov 1 2020, 1:33 AM · Restricted Project

Oct 28 2020

eduucaldas updated the diff for D90240: [SyntaxTree] Add reverse links to syntax Nodes..

Answered all comments but:

  • Add tests for replaceChildRangeLowLevel
  • Asymmetry of replaceChildRangeLowLevel, do we need to separate children of the replaced range?
Oct 28 2020, 9:33 AM · Restricted Project
eduucaldas updated the diff for D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 28 2020, 6:00 AM · Restricted Project
eduucaldas updated the diff for D90240: [SyntaxTree] Add reverse links to syntax Nodes..

Rebase to include ChildIterator patch.

Oct 28 2020, 5:48 AM · Restricted Project
eduucaldas updated subscribers of D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring..

Sam, this patch is outdated, as we're still making decisions on https://reviews.llvm.org/D90161 and we haven't yet landed https://reviews.llvm.org/D90240, please don't bother reviewing it.

Oct 28 2020, 4:47 AM · Restricted Project
eduucaldas abandoned D87925: [Synthesis] Fix: `createTree` only from children that are not backed by source code.
Oct 28 2020, 3:03 AM · Restricted Project
eduucaldas updated subscribers of D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring..

This patch will build upon https://reviews.llvm.org/D90240 and https://reviews.llvm.org/D90161
When those patches land, work on this patch will resume.
It is here to illustrate the relevance of the previous patches and the general direction we're going.

Oct 28 2020, 2:15 AM · Restricted Project
eduucaldas added inline comments to D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 28 2020, 2:10 AM · Restricted Project
eduucaldas updated the diff for D90240: [SyntaxTree] Add reverse links to syntax Nodes..
  • replaceChildRangeLowLevel now takes Begin instead of BeforeBegin
  • appendChildLowLevel
Oct 28 2020, 1:48 AM · Restricted Project

Oct 27 2020

eduucaldas updated the diff for D90161: [SyntaxTree] Provide iterators for Lists.
  • const on getElement and similar.
  • NotSentinel -> Element
Oct 27 2020, 9:00 AM · Restricted Project
eduucaldas added a comment to D90161: [SyntaxTree] Provide iterators for Lists.

I left some points unanswered, I'll answer them tomorrow :)

Oct 27 2020, 8:57 AM · Restricted Project
eduucaldas added a reviewer for D90240: [SyntaxTree] Add reverse links to syntax Nodes.: gribozavr2.
Oct 27 2020, 8:34 AM · Restricted Project
eduucaldas updated the summary of D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 27 2020, 8:28 AM · Restricted Project
eduucaldas requested review of D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 27 2020, 8:27 AM · Restricted Project

Oct 26 2020

eduucaldas updated the diff for D90161: [SyntaxTree] Provide iterators for Lists.

Diff against master, sorry about that

Oct 26 2020, 9:36 AM · Restricted Project
eduucaldas abandoned D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Oct 26 2020, 9:27 AM · Restricted Project
eduucaldas updated the diff for D90161: [SyntaxTree] Provide iterators for Lists.

Fix comment.

Oct 26 2020, 9:26 AM · Restricted Project
eduucaldas added a comment to D90161: [SyntaxTree] Provide iterators for Lists.

Could you add tests that verify the pairing of elements and delimiters?

Those are surfaced through the previous tests, via getElementsAsNodesAndDelimiters

Oct 26 2020, 9:20 AM · Restricted Project
eduucaldas accepted D90023: [Syntax] Add iterators over children of syntax trees..

Thanks for the instructive replies

Oct 26 2020, 9:12 AM · Restricted Project
eduucaldas accepted D90163: [Syntax] Disallow invalid Node operations.
Oct 26 2020, 9:06 AM · Restricted Project
eduucaldas updated subscribers of D90161: [SyntaxTree] Provide iterators for Lists.
Oct 26 2020, 8:30 AM · Restricted Project
eduucaldas added a reviewer for D90161: [SyntaxTree] Provide iterators for Lists: gribozavr2.
Oct 26 2020, 8:28 AM · Restricted Project
eduucaldas updated the summary of D90161: [SyntaxTree] Provide iterators for Lists.
Oct 26 2020, 8:27 AM · Restricted Project
eduucaldas requested review of D90161: [SyntaxTree] Provide iterators for Lists.
Oct 26 2020, 8:26 AM · Restricted Project

Oct 23 2020

eduucaldas added a comment to D90023: [Syntax] Add iterators over children of syntax trees..

Thanks Sam! I learned a lot from your patch ^^

Oct 23 2020, 10:40 AM · Restricted Project

Oct 21 2020

eduucaldas added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Oct 21 2020, 2:57 AM · Restricted Project
eduucaldas added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Oct 21 2020, 1:18 AM · Restricted Project

Oct 20 2020

eduucaldas abandoned D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..
Oct 20 2020, 7:47 AM · Restricted Project
eduucaldas requested review of D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring..
Oct 20 2020, 7:46 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

rename getBeforeBegin

Oct 20 2020, 6:12 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Add tests, ElementAndDelimiter are input iterators

Oct 20 2020, 5:40 AM · Restricted Project
eduucaldas added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Oct 20 2020, 4:58 AM · Restricted Project

Oct 15 2020

eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Linting

Oct 15 2020, 10:59 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.
  • [SyntaxTree] ElementAndDelimiterIterator is polymorphic and supports BeforeBegin iterator
Oct 15 2020, 10:30 AM · Restricted Project

Oct 14 2020

eduucaldas added inline comments to D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Oct 14 2020, 8:38 AM · Restricted Project
eduucaldas added a comment to D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Haven't yet implemented BeforeBegin, waiting for a heads up on the patch as is.

Oct 14 2020, 8:31 AM · Restricted Project
eduucaldas added inline comments to D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Oct 14 2020, 8:30 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.
  • Make ElementAndDelimiterIterator templated.
Oct 14 2020, 8:30 AM · Restricted Project
eduucaldas updated the diff for D89148: [SyntaxTree] Artificial use of the Mutations API..

Rebase

Oct 14 2020, 2:48 AM · Restricted Project
eduucaldas added inline comments to D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.
Oct 14 2020, 2:42 AM · Restricted Project
eduucaldas committed rG6fbad9bf304c: [SyntaxTree][NFC] Nit on `replaceChildRangeLowLevel` (authored by eduucaldas).
[SyntaxTree][NFC] Nit on `replaceChildRangeLowLevel`
Oct 14 2020, 2:41 AM
eduucaldas committed rG72732acade77: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`. (authored by eduucaldas).
[SyntaxTree] Bug fix in `MutationsImpl::addAfter`.
Oct 14 2020, 2:26 AM
eduucaldas closed D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`..
Oct 14 2020, 2:26 AM · Restricted Project
eduucaldas committed rG4178f8f2f08e: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel` (authored by eduucaldas).
[SyntaxTree] Improve safety of `replaceChildRangeLowLevel`
Oct 14 2020, 2:21 AM
eduucaldas closed D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.
Oct 14 2020, 2:21 AM · Restricted Project
eduucaldas updated the diff for D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.

Answer to comments

Oct 14 2020, 2:08 AM · Restricted Project

Oct 13 2020

eduucaldas committed rGa8f1790fdb8c: [SyntaxTree] Fix rtti for `Expression`. (authored by eduucaldas).
[SyntaxTree] Fix rtti for `Expression`.
Oct 13 2020, 7:48 AM
eduucaldas closed D89146: [SyntaxTree] Fix rtti for `Expression`..
Oct 13 2020, 7:48 AM · Restricted Project
eduucaldas updated the diff for D89146: [SyntaxTree] Fix rtti for `Expression`..

rebase

Oct 13 2020, 6:19 AM · Restricted Project
eduucaldas added a reviewer for D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`.: gribozavr2.
Oct 13 2020, 6:16 AM · Restricted Project
eduucaldas requested review of D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`..
Oct 13 2020, 6:15 AM · Restricted Project
eduucaldas added a reviewer for D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`: gribozavr2.
Oct 13 2020, 2:57 AM · Restricted Project
eduucaldas updated the diff for D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.

minor

Oct 13 2020, 2:56 AM · Restricted Project
eduucaldas updated the diff for D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.

minor

Oct 13 2020, 2:49 AM · Restricted Project
eduucaldas requested review of D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.
Oct 13 2020, 2:47 AM · Restricted Project

Oct 12 2020

eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Answer comments, TODO: think about templated iterators

Oct 12 2020, 6:29 AM · Restricted Project
eduucaldas updated subscribers of D89148: [SyntaxTree] Artificial use of the Mutations API..

This patch implements the use case we discussed. It is merely for illustration.

Oct 12 2020, 1:37 AM · Restricted Project
eduucaldas added a reviewer for D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`.: gribozavr2.
Oct 12 2020, 1:34 AM · Restricted Project
eduucaldas updated the diff for D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..

Add asserts to MutationsImpl::remove

Oct 12 2020, 1:28 AM · Restricted Project
eduucaldas updated the diff for D89146: [SyntaxTree] Fix rtti for `Expression`..

Rebase

Oct 12 2020, 12:05 AM · Restricted Project

Oct 10 2020

eduucaldas updated the diff for D89148: [SyntaxTree] Artificial use of the Mutations API..

Rebase

Oct 10 2020, 1:29 AM · Restricted Project
eduucaldas updated the diff for D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..

Fix whitespacing

Oct 10 2020, 1:20 AM · Restricted Project
eduucaldas updated the diff for D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..

Add role sanity-check. Introduce GetBegin().

Oct 10 2020, 1:16 AM · Restricted Project
eduucaldas updated the summary of D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..
Oct 10 2020, 12:21 AM · Restricted Project
eduucaldas updated the summary of D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..
Oct 10 2020, 12:20 AM · Restricted Project
eduucaldas updated the diff for D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..

Add reachability assertions

Oct 10 2020, 12:19 AM · Restricted Project

Oct 9 2020

eduucaldas requested review of D89148: [SyntaxTree] Artificial use of the Mutations API..
Oct 9 2020, 10:12 AM · Restricted Project
eduucaldas requested review of D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`..
Oct 9 2020, 10:09 AM · Restricted Project
eduucaldas requested review of D89146: [SyntaxTree] Fix rtti for `Expression`..
Oct 9 2020, 10:08 AM · Restricted Project

Oct 8 2020

eduucaldas added a reviewer for D88106: [SyntaxTree] Provide iterator-like functions for Lists: gribozavr2.

This is quite low priority, compared to the other branches of work, but it was almost ready work, so I decided to polish it and send it to review now.

Oct 8 2020, 10:34 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Replace auto .. = std::vector(); with std::vector ..;

Oct 8 2020, 10:00 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Reorganize methods to minimize diffs

Oct 8 2020, 9:47 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.

Better comments

Oct 8 2020, 9:42 AM · Restricted Project
eduucaldas updated the diff for D88106: [SyntaxTree] Provide iterator-like functions for Lists.
  • [SyntaxTree] Provide iterator for List that iterates through ElementAndDelimiters even for not well-defined lists.
Oct 8 2020, 9:27 AM · Restricted Project

Oct 1 2020

eduucaldas committed rG5011d43108d1: Migrate Declarators to use the List API (authored by eduucaldas).
Migrate Declarators to use the List API
Oct 1 2020, 6:57 AM
eduucaldas closed D88403: Migrate Declarators to use the List API.
Oct 1 2020, 6:57 AM · Restricted Project

Sep 29 2020

eduucaldas updated the diff for D88403: Migrate Declarators to use the List API.

Update tests

Sep 29 2020, 10:55 AM · Restricted Project
eduucaldas updated the diff for D88403: Migrate Declarators to use the List API.

Improve comment

Sep 29 2020, 1:24 AM · Restricted Project
eduucaldas added inline comments to D88403: Migrate Declarators to use the List API.
Sep 29 2020, 1:23 AM · Restricted Project

Sep 28 2020

eduucaldas added a reviewer for D88403: Migrate Declarators to use the List API: gribozavr2.
Sep 28 2020, 5:40 AM · Restricted Project
eduucaldas updated the summary of D88403: Migrate Declarators to use the List API.
Sep 28 2020, 4:59 AM · Restricted Project
eduucaldas requested review of D88403: Migrate Declarators to use the List API.
Sep 28 2020, 4:56 AM · Restricted Project

Sep 22 2020

eduucaldas committed rGc3c08bfdfd62: [SyntaxTree] Test the List API (authored by eduucaldas).
[SyntaxTree] Test the List API
Sep 22 2020, 10:08 AM
eduucaldas closed D87839: [SyntaxTree] Test the List API.
Sep 22 2020, 10:08 AM · Restricted Project
eduucaldas requested review of D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Sep 22 2020, 9:38 AM · Restricted Project
eduucaldas added inline comments to D87839: [SyntaxTree] Test the List API.
Sep 22 2020, 9:23 AM · Restricted Project
eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.

.

Sep 22 2020, 9:22 AM · Restricted Project
eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.

Answer code review.

Sep 22 2020, 9:22 AM · Restricted Project
eduucaldas committed rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag. (authored by eduucaldas).
[SyntaxTree] Add tests for the assignment of the `canModify` tag.
Sep 22 2020, 6:17 AM
eduucaldas closed D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..
Sep 22 2020, 6:17 AM · Restricted Project
eduucaldas added a comment to D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..

Looking for feedback, specially on the names I used.
Also if you have ideas of interesting tests they will be gladly accepted :)

Sep 22 2020, 2:57 AM · Restricted Project