This is the final patch for the IR TableGen files cleanup.
It deals with the intrinsics for NVVM.
Paths
| Differential D91097
[IR] [TableGen] Cleanup pass over the IR TableGen files, part 2 ClosedPublic Authored by Paul-C-Anagnostopoulos on Nov 9 2020, 12:25 PM.
Details Summary This is the final patch for the IR TableGen files cleanup. It deals with the intrinsics for NVVM.
Diff Detail
Unit TestsFailed
Event TimelineComment Actions LGTM overall, modulo one cosmetic nit.
This revision is now accepted and ready to land.Nov 9 2020, 1:12 PM
Closed by commit rG467208a4926a: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2 (authored by Paul-C-Anagnostopoulos). · Explain WhyNov 10 2020, 6:29 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 303955 llvm/include/llvm/IR/IntrinsicsNVVM.td
|
I'd keep the original version, including the formatting -- I think it's substantially more readable that way. Understanding the uniformly nested set of foldl() is mentally easier to grok than the mix of foldl and foreach with args wrapped differently at each level.
IMO, it's one of the cases where nominally better code is not necessarily an improvement overall.