Page MenuHomePhabricator

[MemorySSA] Extend walker API taking in a MemoryLocation to take in a Stop access.
Needs ReviewPublic

Authored by asbirlea on Mon, Nov 2, 6:26 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

draft

Diff Detail

Unit TestsFailed

TimeTest
390 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
580 mswindows > LLVM.CodeGen/AMDGPU::ds_read2.ll
Script: -- : 'RUN: at line 2'; c:\ws\w16-1\llvm-project\premerge-checks\build\bin\llc.exe -march=amdgcn -mcpu=bonaire -verify-machineinstrs -mattr=+load-store-opt < C:\ws\w16-1\llvm-project\premerge-checks\llvm\test\CodeGen\AMDGPU\ds_read2.ll | c:\ws\w16-1\llvm-project\premerge-checks\build\bin\filecheck.exe -enable-var-scope -check-prefixes=GCN,CI C:\ws\w16-1\llvm-project\premerge-checks\llvm\test\CodeGen\AMDGPU\ds_read2.ll

Event Timeline

asbirlea created this revision.Mon, Nov 2, 6:26 PM
asbirlea requested review of this revision.Mon, Nov 2, 6:26 PM
nikic added a subscriber: nikic.Sun, Nov 8, 10:47 AM
nikic added inline comments.
llvm/lib/Analysis/MemorySSA.cpp
966

I would make assert(!Stop || MSSA.dominates(Stop, Start)) a precondition for specifying the stop access. I don't think the intended semantics of a non-dominating stop point are clear, and I don't see an immediate use-case.