This is an archive of the discontinued LLVM Phabricator instance.

[MemorySSA] Extend walker API taking in a MemoryLocation to take in a Stop access.
Needs ReviewPublic

Authored by asbirlea on Nov 2 2020, 6:26 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

draft

Diff Detail

Event Timeline

asbirlea created this revision.Nov 2 2020, 6:26 PM
asbirlea requested review of this revision.Nov 2 2020, 6:26 PM
nikic added a subscriber: nikic.Nov 8 2020, 10:47 AM
nikic added inline comments.
llvm/lib/Analysis/MemorySSA.cpp
966

I would make assert(!Stop || MSSA.dominates(Stop, Start)) a precondition for specifying the stop access. I don't think the intended semantics of a non-dominating stop point are clear, and I don't see an immediate use-case.