Page MenuHomePhabricator
Differential D90163

[Syntax] Disallow invalid Node operations
ClosedPublic
Actions

Authored by sammccall on Oct 26 2020, 8:44 AM.

Details

Reviewers
gribozavr
eduucaldas
gribozavr2
Commits
rGc6a05eb62f2a: [Syntax] Disallow invalid Node operations
Summary

Copy/move break invariants (move could be fixed).
Node/Tree should have no public constructors, they're abstract.
Destructor is private to enforce arena allocation.

(Making the constructor of all subclasses private doesn't seem worthwhile)

Diff Detail

Event Timeline

sammccall created this revision.Oct 26 2020, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2020, 8:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall requested review of this revision.Oct 26 2020, 8:44 AM
gribozavr2 accepted this revision.Oct 26 2020, 8:51 AM
This revision is now accepted and ready to land.Oct 26 2020, 8:51 AM
sammccall mentioned this in D90023: [Syntax] Add iterators over children of syntax trees..Oct 26 2020, 8:54 AM
eduucaldas accepted this revision.Oct 26 2020, 9:06 AM
Harbormaster completed remote builds in B76413: Diff 300687.Oct 26 2020, 9:27 AM
Closed by commit rGc6a05eb62f2a: [Syntax] Disallow invalid Node operations (authored by sammccall). · Explain WhyOct 27 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.
sammccall added a commit: rGc6a05eb62f2a: [Syntax] Disallow invalid Node operations.

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Tooling/
Syntax/
14 lines

Diff 300908

View Options

clang/include/clang/Tooling/Syntax/Tree.h

Loading...