This is an archive of the discontinued LLVM Phabricator instance.

[amdgpu] Enhance disjoint memory accesses checking.
AbandonedPublic

Authored by hliao on Oct 21 2020, 11:16 AM.

Details

Reviewers
arsenm
rampitec
Summary
  • Follow the same logic as the enhancement in AMDGPU AA.

Diff Detail

Event Timeline

hliao created this revision.Oct 21 2020, 11:16 AM
hliao requested review of this revision.Oct 21 2020, 11:16 AM
arsenm added inline comments.Oct 21 2020, 11:29 AM
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
2844

I think this is too much heavy lifting for areMemAccessesTriviallyDisjoint. The whole point of it is to check based on the instruction itself without relying on the IR/AA

hliao abandoned this revision.Nov 10 2020, 7:10 AM

with multiple MMO is supported in the scheduler, this patch is no longer for performance.