This is an archive of the discontinued LLVM Phabricator instance.

Differential D89763

[Apple-stage2] Install FileCheck and yaml2obj in the toolchain
ClosedPublic

Authored by JDevlieghere on Oct 19 2020, 10:06 PM.

Details

Reviewers
arphaman
Commits
rG27a909a24f99: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain
Summary

rdar://70274446

Diff Detail

Event Timeline

JDevlieghere created this revision.Oct 19 2020, 10:06 PM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 19 2020, 10:06 PM
JDevlieghere requested review of this revision.Oct 19 2020, 10:06 PM
arphaman requested changes to this revision.Oct 20 2020, 8:16 AM
arphaman added inline comments.
clang/cmake/caches/Apple-stage2.cmake
75–76

I think you need the ${LLVM_TOOLCHAIN_UTILITIES} to the distribution components here.

This revision now requires changes to proceed.Oct 20 2020, 8:16 AM
JDevlieghere updated this revision to Diff 299370.Oct 20 2020, 8:29 AM
arphaman accepted this revision.Oct 20 2020, 1:03 PM
This revision is now accepted and ready to land.Oct 20 2020, 1:03 PM
Closed by commit rG27a909a24f99: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain (authored by JDevlieghere). · Explain WhyOct 20 2020, 1:46 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG27a909a24f99: [Apple-stage2] Install FileCheck and yaml2obj in the toolchain.
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2020, 1:46 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
cmake/
caches/
8 lines

Diff 299460

clang/cmake/caches/Apple-stage2.cmake

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Linesset(LLVM_TOOLCHAIN_TOOLS
llvm-cov llvm-cov
llvm-dwarfdump llvm-dwarfdump
llvm-profdata llvm-profdata
llvm-objdump llvm-objdump
llvm-nm llvm-nm
llvm-size llvm-size
CACHE STRING "") CACHE STRING "")
set(LLVM_BUILD_UTILS ON CACHE BOOL "")
set(LLVM_INSTALL_UTILS ON CACHE BOOL "")
set(LLVM_TOOLCHAIN_UTILITIES
FileCheck
yaml2obj
CACHE STRING "")
set(LLVM_DISTRIBUTION_COMPONENTS set(LLVM_DISTRIBUTION_COMPONENTS
clang clang
LTO LTO
clang-format clang-format
clang-resource-headers clang-resource-headers
cxx-headers cxx-headers
Remarks Remarks
${LLVM_TOOLCHAIN_TOOLS} ${LLVM_TOOLCHAIN_TOOLS}
${LLVM_TOOLCHAIN_UTILITIES}
arphamanUnsubmitted
Not Done
ReplyInline Actions

I think you need the ${LLVM_TOOLCHAIN_UTILITIES} to the distribution components here.

arphaman: I think you need the `${LLVM_TOOLCHAIN_UTILITIES}` to the distribution components here.
CACHE STRING "") CACHE STRING "")
# test args # test args
set(LLVM_LIT_ARGS "--xunit-xml-output=testresults.xunit.xml -v" CACHE STRING "") set(LLVM_LIT_ARGS "--xunit-xml-output=testresults.xunit.xml -v" CACHE STRING "")