Page MenuHomePhabricator

Revert "[clang-format] Fix AlignConsecutive on PP blocks"
ClosedPublic

Authored by sylvestre.ledru on Oct 15 2020, 7:08 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 15 2020, 7:08 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sylvestre.ledru requested review of this revision.Oct 15 2020, 7:08 AM
lebedev.ri added inline comments.
clang/unittests/Format/FormatTest.cpp
12255

Passing-by comment: you probably want to keep the tests though?

sylvestre.ledru added inline comments.
clang/unittests/Format/FormatTest.cpp
12255

Sure, i will keep that
and add a test case to avoid breaking what we did

LGTM, only keep the tests if they remain passing, otherwise perhaps @JakeMerdichAMD can add them back in.

Could you add a test for the thing that broke to keep us honest?

@JakeMerdichAMD when you get time, swing back round again with your fix because I think this was a good change (apart of the issues)

Add the test which was failing + add the previous tests (but disabled)

This revision is now accepted and ready to land.Oct 16 2020, 10:26 AM