Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (270 w, 1 d)
Roles
Administrator

Recent Activity

Today

MyDeveloperDay accepted D88956: [clang-format] Fix misformatted macro definitions after D86959.

LGTM

Wed, Oct 21, 1:15 AM · Restricted Project

Yesterday

MyDeveloperDay added a comment to D88239: [clang-format] Fix spaces around */& in multi-variable declarations.

I think this patch needs rebasing

Tue, Oct 20, 7:52 AM · Restricted Project
MyDeveloperDay updated subscribers of D88239: [clang-format] Fix spaces around */& in multi-variable declarations.
Tue, Oct 20, 7:33 AM · Restricted Project
MyDeveloperDay accepted D89709: [clang-format] Drop clangFrontend dependency for FormatTests.

LGTM, I'm for anything that speeds up the build

Tue, Oct 20, 12:19 AM · Restricted Project

Fri, Oct 16

MyDeveloperDay accepted D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".

LGTM

Fri, Oct 16, 10:26 AM · Restricted Project
MyDeveloperDay added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

@catskul I think @STL_MSFT gives justification enough, I'm personally not of the belief there is one true format. I like clang-format to be flexible enough to meet the requirements that @STL_MSFT says, I also don't like @clang-format being the source of friction, and I don't like its constraints being the thing that prevents people from switching to clang-format.

Fri, Oct 16, 2:19 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks".

LGTM, only keep the tests if they remain passing, otherwise perhaps @JakeMerdichAMD can add them back in.

Fri, Oct 16, 2:12 AM · Restricted Project
MyDeveloperDay accepted D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol.

LGTM

Fri, Oct 16, 2:09 AM · Restricted Project

Wed, Oct 14

MyDeveloperDay accepted D88227: [clang-format] Add a SpaceAroundPointerQualifiers style option.

LGTM

Wed, Oct 14, 12:07 PM · Restricted Project
MyDeveloperDay added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

In my opinion this patch should not be merged. I honestly don’t believe
this is a legitimate way of formatting code, so why make it possible at all?

Mostly people want to migrate away from astyle without reviving formatting fights with their team will prevent adoption.

There are many of us stuck with no good options until we're able to convince our teams that clang-format will maintain their preference for whatever reason that preference exists.

Wed, Oct 14, 12:01 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 9

MyDeveloperDay added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

Not to my knowledge, if we are not going to fix it we should probably revert it for now

Fri, Oct 9, 2:30 AM · Restricted Project, Restricted Project

Wed, Oct 7

MyDeveloperDay added inline comments to D88956: [clang-format] Fix misformatted macro definitions after D86959.
Wed, Oct 7, 9:31 AM · Restricted Project
MyDeveloperDay added a comment to D88956: [clang-format] Fix misformatted macro definitions after D86959.

I have noticed that clang-format has a tendency to over eagerly make * and & a TT_BinaryOperator, I know its too late to change it now, but sometimes I wonder if they should be detected as TT_PointerOrReference and then the clauses try and expose when they are being used as BinaryOperators we might have better luck.. or maybe not.

Wed, Oct 7, 9:28 AM · Restricted Project

Fri, Sep 25

MyDeveloperDay added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Which bit to you find more complex? adding something to the FormatToken or the use of the is() calls?

Fri, Sep 25, 7:41 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D88296: [clang-format] De-duplicate includes with leading or trailing whitespace..

This LGTM, generally I think clang-format seems to remove trailing spaces anyway so it might be that the duplicate might disappear on the second format. but I'm good with this approach

Fri, Sep 25, 7:37 AM · Restricted Project

Thu, Sep 24

MyDeveloperDay added inline comments to D88239: [clang-format] Fix spaces around */& in multi-variable declarations.
Thu, Sep 24, 2:31 PM · Restricted Project
MyDeveloperDay added inline comments to D88227: [clang-format] Add a SpaceAroundPointerQualifiers style option.
Thu, Sep 24, 2:26 PM · Restricted Project
MyDeveloperDay added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

@oleg.smolsky I agree, what you have here covers a myriad of other cases and was committed in 2018, we can't call this commit a regression it was a feature ;-), if we want to improve the feature that is something else.

Thu, Sep 24, 2:21 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D52676: [clang-format] tweaked another case of lambda formatting.

I think if you have a proposal for changing the behavior lets see the patch and how it impacts the existing unit tests

Thu, Sep 24, 1:30 AM · Restricted Project, Restricted Project

Tue, Sep 22

MyDeveloperDay added a comment to D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

I noticed the pre-merge tests failed!

Tue, Sep 22, 4:17 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

In the examples you give here.. (and I have a feeling there are others in the tests) some of these fields are the same in all 3 cases

Tue, Sep 22, 4:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Tue, Sep 22, 12:24 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Tue, Sep 22, 12:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

MyDeveloperDay added inline comments to D79388: [clang-format] Fix AlignConsecutive on PP blocks.
Sep 21 2020, 8:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D79388: [clang-format] Fix AlignConsecutive on PP blocks.
Sep 21 2020, 6:50 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D79388: [clang-format] Fix AlignConsecutive on PP blocks.

@JakeMerdichAMD this has caused a regression https://bugs.llvm.org/show_bug.cgi?id=47589

Sep 21 2020, 6:39 AM · Restricted Project, Restricted Project

Sep 18 2020

MyDeveloperDay accepted D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py.

LGTM

Sep 18 2020, 12:37 PM · Restricted Project
MyDeveloperDay accepted D86137: Add -Wno-error=unknown flag to clang-format..
Sep 18 2020, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

it certainly LGTM, like I said I've had met this issue before and I think this does get around that situation where perhaps your not even using the option it's complaining about (especially if its a C++ option and you are using clang-format for C#)

Sep 18 2020, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay committed rGa16e4a63ae7c: [clang-format] NFC ensure the clang-format tests remain clang-formatted (authored by MyDeveloperDay).
[clang-format] NFC ensure the clang-format tests remain clang-formatted
Sep 18 2020, 10:17 AM
MyDeveloperDay committed rG2e7add812eb7: [clang-format] Add a option for the position of Java static import (authored by MyDeveloperDay).
[clang-format] Add a option for the position of Java static import
Sep 18 2020, 10:13 AM
MyDeveloperDay closed D87201: [clang-format] Add a option for the position of Java static import.
Sep 18 2020, 10:12 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

IMHO I feel that given that these changes are more wide reaching than just clang-format that it might be more correct for your to request commit access yourself.

Sep 18 2020, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2020

MyDeveloperDay committed rG40e771c1c0d3: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function (authored by MyDeveloperDay).
[clang-format][regression][PR47461] ifdef causes catch to be seen as a function
Sep 17 2020, 5:23 AM
MyDeveloperDay closed D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.
Sep 17 2020, 5:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

LGTM.
Don't we risk any other side effects?

Sep 17 2020, 4:00 AM · Restricted Project, Restricted Project

Sep 16 2020

MyDeveloperDay added a comment to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good reviewer. :)
Also, I think you've made some good points there and I'm going to turn this review into "non-breaking the world" one. I'll be back in a few days with a new diff.

Sep 16 2020, 7:45 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rG4dd9c709ef1b: [clang-format] [NFC] Fix spelling mistake in the documentation (authored by MyDeveloperDay).
[clang-format] [NFC] Fix spelling mistake in the documentation
Sep 16 2020, 5:47 AM
MyDeveloperDay closed D87352: Fix typo.
Sep 16 2020, 5:47 AM · Restricted Project
MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

ping

Sep 16 2020, 5:38 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D87352: Fix typo.
Sep 16 2020, 5:34 AM · Restricted Project
MyDeveloperDay updated subscribers of D87352: Fix typo.
Sep 16 2020, 5:34 AM · Restricted Project

Sep 15 2020

MyDeveloperDay added a comment to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

Firstly let me say thank you for the patch, and taking the time to listen to the reviewers. Please don't be discouraged by my reply/opinon.

Sep 15 2020, 8:14 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87352: Fix typo.
Sep 15 2020, 7:47 AM · Restricted Project
MyDeveloperDay added a comment to D87352: Fix typo.

Ok almost...

Sep 15 2020, 4:25 AM · Restricted Project
MyDeveloperDay requested changes to D87352: Fix typo.

I have realized this is the wrong change

Sep 15 2020, 1:03 AM · Restricted Project

Sep 14 2020

MyDeveloperDay requested changes to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

I have a hard time when people change tests! just because one person wants them this way doesn't mean everyone will.

Sep 14 2020, 8:44 AM · Restricted Project, Restricted Project

Sep 13 2020

MyDeveloperDay updated the diff for D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

Minimize other places where try could be incorrectly seen as an identifier

Sep 13 2020, 3:00 AM · Restricted Project, Restricted Project

Sep 9 2020

MyDeveloperDay accepted D87352: Fix typo.

LGTM, thank you for doing this..

Sep 9 2020, 7:00 AM · Restricted Project
MyDeveloperDay accepted D87201: [clang-format] Add a option for the position of Java static import.

LGTM, I'm happy if @JakeMerdichAMD is

Sep 9 2020, 6:59 AM · Restricted Project, Restricted Project

Sep 8 2020

MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

Note to self, other things could cause the same issue

Sep 8 2020, 9:55 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.
Sep 8 2020, 9:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

@Saldivarcher this should be landed now, please validate

Sep 8 2020, 8:42 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGc81dd3d159ab: [clang-format] Handle shifts within conditions (authored by MyDeveloperDay).
[clang-format] Handle shifts within conditions
Sep 8 2020, 8:40 AM
MyDeveloperDay closed D86581: [clang-format] Handle shifts within conditions.
Sep 8 2020, 8:40 AM · Restricted Project, Restricted Project
MyDeveloperDay abandoned D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer.

Better solution here D86581: [clang-format] Handle shifts within conditions

Sep 8 2020, 8:31 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87201: [clang-format] Add a option for the position of Java static import.
Sep 8 2020, 7:51 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D87201: [clang-format] Add a option for the position of Java static import.
Sep 8 2020, 7:50 AM · Restricted Project, Restricted Project

Sep 7 2020

MyDeveloperDay added a comment to D87028: [clang-format] Improve heuristic for detecting function declarations.

Thanks for the patch, I think this looks like a comprehensive improvement, a new nits only

Sep 7 2020, 1:46 AM · Restricted Project
MyDeveloperDay updated subscribers of D86137: Add -Wno-error=unknown flag to clang-format..

Regarding not touching the LLVM support library: I'd love to find a way, but as clang-format uses the >> operator

Sep 7 2020, 1:39 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D87201: [clang-format] Add a option for the position of Java static import: JakeMerdichAMD.
Sep 7 2020, 1:30 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87201: [clang-format] Add a option for the position of Java static import.

Thanks for the patch, You need to generate a fill context diff (see Contributing to LLVM)

Sep 7 2020, 1:30 AM · Restricted Project, Restricted Project

Sep 5 2020

MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

This has caught me out from time to time, but the presence of such an option can lead to users mixing clang-format versions which could lead to flip/flopping of changes, so I'm not 100% sure it won't drive bad behaviour.

Sep 5 2020, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay removed a project from D86137: Add -Wno-error=unknown flag to clang-format.: Restricted Project.
Sep 5 2020, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a project to D86137: Add -Wno-error=unknown flag to clang-format.: Restricted Project.
Sep 5 2020, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D86137: Add -Wno-error=unknown flag to clang-format.: MyDeveloperDay, JakeMerdichAMD.
Sep 5 2020, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2020

MyDeveloperDay accepted D86930: [clang-format] Handle typename macros inside cast expressions.

LGTM

Sep 4 2020, 10:23 AM · Restricted Project
MyDeveloperDay accepted D86782: [clang-format] Allow configuring list of macros that map to attributes.

LGTM, I think we need something like this for those keywords/macros

Sep 4 2020, 10:22 AM · Restricted Project
MyDeveloperDay accepted D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield.

Assuming it builds with minimum required c++ compiler

Sep 4 2020, 10:21 AM · Restricted Project
MyDeveloperDay accepted D87007: [clang-format] Correctly parse function declarations with TypenameMacros.

LGTM

Sep 4 2020, 10:20 AM · Restricted Project
MyDeveloperDay accepted D86950: [clang-format] Check that */& after typename macros are pointers/references.

LGTM

Sep 4 2020, 10:19 AM · Restricted Project
MyDeveloperDay accepted D86959: [clang-format] Fix formatting of _Atomic() qualifier.

This LGTM

Sep 4 2020, 8:07 AM · Restricted Project
MyDeveloperDay added a comment to D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield.

I'm not a C++ language lawyer so I'm not sure which standard introduce enum inheritance? (maybe its something we could always do?), if its a recent change we just need to ensure we are conforming to the C++ version that is needed to build clang.

Sep 4 2020, 8:05 AM · Restricted Project
MyDeveloperDay accepted D86941: [clang-format] Add a test showing the current config file list parsing.

LGTM

Sep 4 2020, 7:58 AM · Restricted Project
MyDeveloperDay accepted D86926: FormatTest: Provide real line number in failure messages.

This LGTM, I've certainly been bit myself in the past with not knowing which test actually failed especially when they are all foo() something.. thank you

Sep 4 2020, 7:57 AM · Restricted Project
MyDeveloperDay accepted D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier.

LGTM

Sep 4 2020, 7:53 AM · Restricted Project

Sep 2 2020

MyDeveloperDay accepted D86960: [clang-format] Parse __underlying_type(T) as a type.

LGTM

Sep 2 2020, 4:15 AM · Restricted Project

Sep 1 2020

MyDeveloperDay added a comment to D86782: [clang-format] Allow configuring list of macros that map to attributes.

I'm wondering if this could be used to help the CUDA usages of clang-format

Sep 1 2020, 7:03 AM · Restricted Project
MyDeveloperDay added inline comments to D86926: FormatTest: Provide real line number in failure messages.
Sep 1 2020, 7:02 AM · Restricted Project

Aug 28 2020

MyDeveloperDay accepted D86716: [clang-format] Detect pointer qualifiers in cast expressions.

This LGTM thank you

Aug 28 2020, 3:01 AM · Restricted Project
MyDeveloperDay accepted D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier.

LGTM thank you for these updates

Aug 28 2020, 2:58 AM · Restricted Project

Aug 27 2020

MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

@Saldivarcher do you have commit access?

Aug 27 2020, 5:11 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D86581: [clang-format] Handle shifts within conditions.

I think this LGTM and the solution is much more elegant than mine! You were not stepping on my toes, I'm always happy for someone else to take things over and this is a much smarter solution than mine.

Aug 27 2020, 1:27 AM · Restricted Project, Restricted Project

Aug 26 2020

MyDeveloperDay added reviewers for D86581: [clang-format] Handle shifts within conditions: JakeMerdichAMD, krasimir.
Aug 26 2020, 7:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

I think I like your solution better than mine D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer, could you look at my unit tests and consider adding them here?

Aug 26 2020, 7:06 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D86597: [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h.

LGTM

Aug 26 2020, 7:04 AM · Restricted Project

Jul 28 2020

MyDeveloperDay accepted D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Thank you for the patch, this LGTM, I think this kind of change should help reduce memory usage and I feel improves the readability.

Jul 28 2020, 2:01 AM · Restricted Project, Restricted Project

Jul 27 2020

MyDeveloperDay added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

a new minor Nits but looks good.

Jul 27 2020, 2:33 AM · Restricted Project, Restricted Project

Jul 23 2020

MyDeveloperDay added reviewers for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: JakeMerdichAMD, wanders, curdeius.
Jul 23 2020, 2:37 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Thank you for the patch, I'm generally in agreement but I think we should let some others comment

Jul 23 2020, 2:37 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..
Jul 23 2020, 2:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: krasimir, sammccall.
Jul 23 2020, 2:14 AM · Restricted Project, Restricted Project

Jul 21 2020

MyDeveloperDay closed D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D84090: [clang-format] Add BitFieldColonSpacing option.

just reopening to formally accept

Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay reopened D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D84090: [clang-format] Add BitFieldColonSpacing option.

Thanks for assistance and review. And sorry about the extra noise.

Jul 21 2020, 2:08 AM · Restricted Project, Restricted Project

Jul 20 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

Nit:clang-format the patch

Jul 20 2020, 8:33 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84103: [clang-format] Make sure rst documentation matches comments.

Thanks for doing this..

Jul 20 2020, 1:41 AM · Restricted Project, Restricted Project

Jul 19 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

Let’s do all 4, None, Both, Left, Right

Jul 19 2020, 12:26 AM · Restricted Project, Restricted Project

Jul 18 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

you need to make a full contextdiff git diff -U 99999999

Jul 18 2020, 7:02 AM · Restricted Project, Restricted Project