# Projects

User does not belong to any projects.

# User Details

User Since
Nov 12 2020, 2:35 AM (10 w, 4 d)

# Yesterday

Do you need someone to push this? If so please post email and name to use for the commit.

Sun, Jan 24, 12:53 PM · Restricted Project, Restricted Project

I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could annotate enums which don't have to be fully documented?

Sun, Jan 24, 11:52 AM · Restricted Project, Restricted Project

# Fri, Jan 22

HazardyKnusperkeks added a comment to D95017: [clang-format] add case aware include sorting.

I can push that, but will wait a bit longer so the others have time to object.

Fri, Jan 22, 8:17 AM · Restricted Project, Restricted Project

# Thu, Jan 21

HazardyKnusperkeks requested review of D95128: [clang-format] [NFC] Remove unused arguments.
Thu, Jan 21, 4:54 AM · Restricted Project, Restricted Project

Empty lines removed.

Thu, Jan 21, 4:41 AM · Restricted Project, Restricted Project

LGTM.

Thu, Jan 21, 4:27 AM · Restricted Project, Restricted Project

Now with assert.

Thu, Jan 21, 4:11 AM · Restricted Project, Restricted Project

# Wed, Jan 20

HazardyKnusperkeks added a comment to D95017: [clang-format] add case aware include sorting.

Please expand the test case to different options like grouping. Otherwise looks good.

Wed, Jan 20, 9:33 PM · Restricted Project, Restricted Project
Wed, Jan 20, 12:52 PM · Restricted Project, Restricted Project
Wed, Jan 20, 12:37 PM · Restricted Project, Restricted Project

How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.

Sorry, much to do work-wise currently. I'll get to the last details today and finish this!

Wed, Jan 20, 7:16 AM · Restricted Project, Restricted Project

How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.

Wed, Jan 20, 12:50 AM · Restricted Project, Restricted Project

# Tue, Jan 19

Is there a test with indentation within a namespace? If not maybe you should add one.

Tue, Jan 19, 11:31 PM · Restricted Project, Restricted Project

Found and fixed the case when no BasedOnStyle apart from InheritParentConfig is used.

Tue, Jan 19, 1:45 PM · Restricted Project, Restricted Project
[clang-format] Apply Allman style to lambdas
Tue, Jan 19, 9:18 AM · Restricted Project, Restricted Project

# Mon, Jan 18

HazardyKnusperkeks added a comment to D94906: [clang-format] Apply Allman style to lambdas.

I think that would have helped me also. I think it's not that easy, but honestly never checked.

Mon, Jan 18, 12:19 PM · Restricted Project, Restricted Project

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Yes I do, but I will try to make it clearer in the tests.

Mon, Jan 18, 10:13 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D94906: [clang-format] Apply Allman style to lambdas.

Formatting corrected.

Mon, Jan 18, 7:52 AM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D94906: [clang-format] Apply Allman style to lambdas.
Mon, Jan 18, 4:20 AM · Restricted Project, Restricted Project

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Mon, Jan 18, 2:45 AM · Restricted Project, Restricted Project
• Rebased
• Renamed to InhteritParentConfig
• Reworked to remove the recursion of getStyle
• Now supports the command line style options
• Test cases extended for the latter
Mon, Jan 18, 2:16 AM · Restricted Project, Restricted Project
• Rebased
• Fixed(?) the last UnitTest, please take a look @krasimir
Mon, Jan 18, 2:11 AM · Restricted Project, Restricted Project
[clang-format] Fix documentation of bcc1dee600
HazardyKnusperkeks updated the diff for D93776: [clang-format] Add StatementAttributeLikeMacros option.

Fix documentation.

Mon, Jan 18, 2:01 AM · Restricted Project, Restricted Project

# Sun, Jan 17

Sun, Jan 17, 10:02 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D93776: [clang-format] Add StatementAttributeLikeMacros option.

Sorting corrected.

Sun, Jan 17, 10:00 PM · Restricted Project, Restricted Project
Sun, Jan 17, 11:42 AM · Restricted Project, Restricted Project

# Sat, Jan 16

Not what I had in mind, but for me that's okay. I can not say anything to the change of the script though.

Sat, Jan 16, 6:24 AM · Restricted Project, Restricted Project

# Fri, Jan 15

Fri, Jan 15, 2:59 PM · Restricted Project, Restricted Project

I think I would remove the code examples from the "AlignConsecutive style" to avoid confusion (that would be the first change)

then perhaps regenerate and update the documentation so we can then see, its seems most have a "code block", can the specific examples not go into that area?

And just have the enum explain its different configuration options?

/// \brief If ``true``, aligns consecutive C/C++ preprocessor macros.
///
/// This will align C/C++ preprocessor macros of consecutive lines.
/// Will result in formattings like
/// \code
///   #define SHORT_NAME       42
///   #define LONGER_NAME      0x007f
///   #define EVEN_LONGER_NAME (2)
///   #define foo(x)           (x * x)
///   #define bar(y, z)        (y + z)
/// \endcode
bool AlignConsecutiveMacros;
Fri, Jan 15, 2:58 PM · Restricted Project, Restricted Project

*ping*
And I don't have a better name.

Fri, Jan 15, 2:56 PM · Restricted Project, Restricted Project

# Thu, Jan 14

Thu, Jan 14, 7:51 AM · Restricted Project, Restricted Project

I would add a test where you have a member before the first access modifier.
Also this is not exactly what they wanted in the bug, as far as I can see members of structs or classes with no access modifier at all should only be indented once.

Thu, Jan 14, 4:03 AM · Restricted Project, Restricted Project

My assumption is that you want to stick with the minimum and maximum is that correct?

Thu, Jan 14, 2:13 AM · Restricted Project, Restricted Project

# Wed, Jan 13

HazardyKnusperkeks added inline comments to D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Wed, Jan 13, 10:17 PM · Restricted Project, Restricted Project
Wed, Jan 13, 2:18 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Wed, Jan 13, 11:59 AM · Restricted Project, Restricted Project

Apart from that last naming issue looks good to me.

Wed, Jan 13, 11:53 AM · Restricted Project, Restricted Project

# Sun, Jan 10

Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)

Sun, Jan 10, 12:44 PM · Restricted Project, Restricted Project

# Sat, Jan 9

Diff updated. Previous diff was generated after rebase, and Phabricator change preview did not show any unrelated changes, so I thought that everything is fine.

Sat, Jan 9, 5:46 AM · Restricted Project, Restricted Project

# Thu, Jan 7

I think your base for the diff is wrong, there are many "added" things which are already in clang-format. Could you update the diff?

Thu, Jan 7, 12:57 AM · Restricted Project, Restricted Project

# Tue, Jan 5

Tue, Jan 5, 12:21 PM · Restricted Project, Restricted Project

# Mon, Jan 4

Mon, Jan 4, 12:34 PM · Restricted Project, Restricted Project

Ideally we should add a comment to the release notes, (which you could do via a separate NFC commit if you wanted)

Thank, I'll do that. But before that, I will create a revision that adds the same feature for the other three alignment types.

Mon, Jan 4, 12:28 PM · Restricted Project, Restricted Project

# Sun, Jan 3

HazardyKnusperkeks added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I think accepting a revision that includes only a fix for AfterEnum being ignored (not the corner case) and the new unit test would be the best way to go about this, since they're separate bugs. Then I can fix the corner case (and compatibility with the new unit test) in a separate differential.

However, as I've already mentioned, I'm new here, so I defer to the judgment of those more experienced.

Sun, Jan 3, 5:14 AM · Restricted Project, Restricted Project

# Wed, Dec 30

HazardyKnusperkeks added a comment to D93938: [clang-format] Fixed AfterEnum handling.

You should add tests to prove what you are doing.

Wed, Dec 30, 2:11 AM · Restricted Project, Restricted Project

# Tue, Dec 29

I like what you are suggesting, do you think BasedOnStyle: File is the best terminology as the term File is used elsewhere to mean read from the .clang_format file, how about

BasedOnStyle: Inherit
BasedOnStyle: InheritFromParent
BasedOnStyle: InheritFromFile

or why not just

BasedOnStyle: InheritParentConfig

to match clang-tidy?

Tue, Dec 29, 12:52 PM · Restricted Project, Restricted Project

I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory?

It's my understanding this is akin to the InheritParentConfig option found in .clang-tidy.
The idea is you can put a .clang-format file in your project root, then for specific directories you can add another .clang-format file that modifies that root .clang-format
The example here is a test folder that needs extended lines but want the rest of the formatting to match the root folder without having to copy the contents of the root and make the small edit.

We have it quite lucky here at LLVM where for tests we can just use:

BasedOnStyle: LLVM
ColumnLimit: 0

However for other projects with their own style they could then use:

# Copy the root directory clang.format config
BasedOnStyle: file
ColumnLimit: 0

This would also make modifying the formatting style of a project much easier as you would only need to touch the root directory .clang-format file in most cases.

Tue, Dec 29, 12:51 AM · Restricted Project, Restricted Project

# Mon, Dec 28

Mon, Dec 28, 7:12 AM · Restricted Project, Restricted Project

# Sun, Dec 27

I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory?

Sun, Dec 27, 3:03 PM · Restricted Project, Restricted Project
Sun, Dec 27, 1:38 PM · Restricted Project, Restricted Project
Sun, Dec 27, 12:50 PM · Restricted Project, Restricted Project
Sun, Dec 27, 1:34 AM · Restricted Project, Restricted Project

This didn't really address the comments, what is the point of the maximum? what if the maximum is > the ColumnLimit?

Sun, Dec 27, 1:29 AM · Restricted Project, Restricted Project

I'm back!
I've reworked the change to correctly(*) work with line comment sections.

Sun, Dec 27, 1:12 AM · Restricted Project, Restricted Project

# Dec 24 2020

If that's how it's supposed to look, than this patch is fine.

Dec 24 2020, 1:53 PM · Restricted Project, Restricted Project

# Dec 23 2020

Seems okay at the first glance. I'm wondering if we can find a better name though.

Dec 23 2020, 1:39 PM · Restricted Project, Restricted Project
Dec 23 2020, 1:18 PM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D93776: [clang-format] Add StatementAttributeLikeMacros option.
Dec 23 2020, 1:16 PM · Restricted Project, Restricted Project
[clang-format] Fix handling of TextProto comments
Dec 23 2020, 1:08 PM · Restricted Project, Restricted Project
Dec 23 2020, 1:08 PM · Restricted Project, Restricted Project

# Dec 22 2020

This looks good to me.

Dec 22 2020, 2:09 PM · Restricted Project, Restricted Project

# Dec 21 2020

So, I've tested a bit:

//= Die ID
//~ foo bar
//~ EinWort Ein langer Text der fortgesetzt wird
//: Dies ist ein langer Kommentar
//: der umgebrochen wird
tr("Foo");

Results in

<message id="Die ID">
<location filename="wid.cpp" line="9"/>
<source>Foo</source>
<extracomment>Dies ist ein langer Kommentar der umgebrochen wird</extracomment>
<translation type="unfinished"></translation>
<extra-EinWort>Ein langer Text der fortgesetzt wird</extra-EinWort>
<extra-foo>bar</extra-foo>
</message>
Dec 21 2020, 1:06 PM · Restricted Project, Restricted Project
Dec 21 2020, 7:20 AM · Restricted Project, Restricted Project
Dec 21 2020, 7:12 AM · Restricted Project, Restricted Project

# Dec 18 2020

HazardyKnusperkeks updated the diff for D93240: [clang-format] Add SpaceBeforeCaseColon option.

Dec 18 2020, 12:58 PM · Restricted Project, Restricted Project
[clang-format][NFC] Expand BreakBeforeBraces examples
Dec 18 2020, 10:08 AM · Restricted Project, Restricted Project

So I guess my question is:

1. is this useful to pursue (either as is, or by switching to us the reformat method)
2. is this useful standalone as the first pass
3. is adding support for JSON something people would welcome (as we did with C#)

If the answer is no, then I don't want to waste the effort trying to fathom how we might do this inside reformat.

Dec 18 2020, 6:40 AM · Restricted Project, Restricted Project

I don't know if this really fixes the problem.

Dec 18 2020, 6:15 AM · Restricted Project, Restricted Project

# Dec 15 2020

I generally don't have the same aversion to new options than others have, but can you point out a style guide that might want this option. (that is kind of the process)

Dec 15 2020, 12:23 PM · Restricted Project, Restricted Project
Dec 15 2020, 11:47 AM · Restricted Project, Restricted Project
Dec 15 2020, 11:46 AM · Restricted Project, Restricted Project
Dec 15 2020, 12:04 AM · Restricted Project, Restricted Project

# Dec 14 2020

Dec 14 2020, 11:12 PM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D93240: [clang-format] Add SpaceBeforeCaseColon option.
Dec 14 2020, 1:21 PM · Restricted Project, Restricted Project

This didn't really address the comments, what is the point of the maximum?

Dec 14 2020, 1:13 PM · Restricted Project, Restricted Project

# Dec 13 2020

Could we consider dropping the maximum?

Dec 13 2020, 6:02 AM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rG36306403d492: [clang-format] Remove double trim (authored by HazardyKnusperkeks).
[clang-format] Remove double trim
Dec 13 2020, 5:34 AM · Restricted Project, Restricted Project

# Dec 12 2020

HazardyKnusperkeks requested review of D93170: [clang-format][NFC] Expand BreakBeforeBraces examples.
Dec 12 2020, 2:20 PM · Restricted Project, Restricted Project
Dec 12 2020, 8:49 AM · Restricted Project, Restricted Project

# Dec 8 2020

Can I assume you need someone to land this for you?

Yes I do. But I have a question, my last change is commited in your name, that means git blame would blame it on you, right?

You can set me as author:
Björn Schäpers <bjoern@hazardy.de>
My Github Account is also called HazardyKnusperkeks.

The process is that you add (https://llvm.org/docs/Contributing.html)

Patch By: HazardyKnusperkeks

to the commit message if the user doesn't have commit access, if you want your name against the blame then I recommend applying for commit access yourself.

That is incorrect and does not represent the nowadays reality, i suggest that you look up the docs.

let me know if you still want me to land this

This is one reason why I don’t like landing patches for others, this just confirms that in the future I will generally request people apply for commit access themselves.

Dec 8 2020, 1:19 AM · Restricted Project, Restricted Project

I have only one question, what stands NFC for? I figured something like "no functional change"? But I can't find a definition anywhere.

Dec 8 2020, 1:18 AM · Restricted Project, Restricted Project

# Dec 7 2020

Can I assume you need someone to land this for you?

Yes I do. But I have a question, my last change is commited in your name, that means git blame would blame it on you, right?

You can set me as author:
Björn Schäpers <bjoern@hazardy.de>
My Github Account is also called HazardyKnusperkeks.

The process is that you add (https://llvm.org/docs/Contributing.html)

Patch By: HazardyKnusperkeks

to the commit message if the user doesn't have commit access, if you want your name against the blame then I recommend applying for commit access yourself.

That is incorrect and does not represent the nowadays reality, i suggest that you look up the docs.

let me know if you still want me to land this

Dec 7 2020, 12:39 PM · Restricted Project, Restricted Project

# Dec 6 2020

Can I assume you need someone to land this for you?

Yes I do. But I have a question, my last change is commited in your name, that means git blame would blame it on you, right?

You can set me as author:
Björn Schäpers <bjoern@hazardy.de>
My Github Account is also called HazardyKnusperkeks.

The process is that you add (https://llvm.org/docs/Contributing.html)

Patch By: HazardyKnusperkeks

to the commit message if the user doesn't have commit access, if you want your name against the blame then I recommend applying for commit access yourself.

let me know if you still want me to land this

Dec 6 2020, 5:40 AM · Restricted Project, Restricted Project
Dec 6 2020, 5:40 AM · Restricted Project, Restricted Project

Can I assume you need someone to land this for you?

Dec 6 2020, 4:37 AM · Restricted Project, Restricted Project

# Dec 4 2020

Dec 4 2020, 1:10 PM · Restricted Project, Restricted Project
Dec 4 2020, 1:09 PM · Restricted Project, Restricted Project

Why is the file mode changed? As far as I know this makes the file executable? (Disclaimer: I'm a primarly windows user.)

Dec 4 2020, 11:50 AM · Restricted Project, Restricted Project

# Dec 3 2020

Dec 3 2020, 12:26 PM · Restricted Project, Restricted Project

# Dec 2 2020

Dec 2 2020, 11:57 AM · Restricted Project, Restricted Project

# Nov 30 2020

Nov 30 2020, 12:30 PM · Restricted Project, Unknown Object (Project)

I think fundamentally from my perspective this seem ok, out of interest can I ask what drove you to require it?

My assumption is that some people write comments like

// Free comment without space

and you want to be able to consistently format it to be (N spaces, as clang-format already does 1 space correct?)

//  Free comment without space

is that correct? is there a common style guide asking for that? what is the rationale

Nov 30 2020, 12:28 PM · Restricted Project, Unknown Object (Project)

# Nov 28 2020

Nov 28 2020, 5:17 AM · Restricted Project, Restricted Project