This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] In documentation, mention possible values for concurrency flags
ClosedPublic

Authored by aganea on Oct 13 2020, 5:21 AM.

Diff Detail

Event Timeline

aganea created this revision.Oct 13 2020, 5:21 AM
aganea requested review of this revision.Oct 13 2020, 5:21 AM
aganea retitled this revision from [ThinLTO] In documentation, mention possible value for concurrency flags to [ThinLTO] In documentation, mention possible values for concurrency flags.
aganea added a reviewer: tejohnson.
hans added a comment.Oct 13 2020, 6:00 AM

Thanks for documenting these!

I wonder if including the "CPU sockets" part is more confusing than helpful (especially if the reader doesn't know about CPU sockets). The sockets don't really matter here anyway.

Sometimes the term "physical core" is used in relation to hyper-threading and I find that pretty understandable. How about something line:

  • 0: Use one thread per physical core (default)
  • 1: Use a single thread only (disable multi-threading)
  • all: Use one thread per logical core (uses all hyper threads)
aganea updated this revision to Diff 297845.Oct 13 2020, 6:44 AM

As suggested by @hans.

hans accepted this revision.Oct 13 2020, 6:49 AM
This revision is now accepted and ready to land.Oct 13 2020, 6:49 AM
This revision was landed with ongoing or failed builds.Oct 13 2020, 6:58 AM
This revision was automatically updated to reflect the committed changes.