Page MenuHomePhabricator

Add initial infra to convert annotations to MD and display summary remarks (WIP)
AbandonedPublic

Authored by fhahn on Oct 12 2020, 7:52 AM.

Details

Reviewers
None

Diff Detail

Unit TestsFailed

TimeTest
350 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

fhahn created this revision.Oct 12 2020, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2020, 7:52 AM
fhahn requested review of this revision.Oct 12 2020, 7:52 AM
thegameg added inline comments.
llvm/lib/IR/Instruction.cpp
127
llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
41
thegameg added inline comments.Fri, Nov 6, 12:07 PM
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
908

How does this get scheduled for LTO? This should probably run after IR linking and all that (when prototyping, I put it in TargetPassConfig for better results, but that doesn't sound like the right place to schedule passes like this in general)

llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
38

One other way would be to walk back the uses of the metadata, but it might not be worth it since it would require a ModulePass.

fhahn updated this revision to Diff 303918.Mon, Nov 9, 10:13 AM

Address most of Francis' comments, thanks!

fhahn marked an inline comment as done.Mon, Nov 9, 10:15 AM
fhahn added inline comments.
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
908

I also added it to the end of the LTO pipeline. Still need to add this for the new PM.

llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp
38

Yeah that would probably be better. I'll try to update the code.

fhahn abandoned this revision.Tue, Nov 10, 11:40 AM

I split up the patch into 2 separate ones: D91195 and D91188