Page MenuHomePhabricator

[AMDGPU] Allow SOP asm mnemonic to differ
ClosedPublic

Authored by Joe_Nash on Oct 1 2020, 3:35 PM.

Details

Summary

Allows the creation of real SOP1 instructions with
assembler mnemonics that differ from their
pseudo-instruction mnemonics. The default behavior
keeps the mnemonics matching.

Corrects a subtarget label typo in a comment.

Diff Detail

Unit TestsFailed

TimeTest
1,140 mslinux > libarcher.parallel::parallel-nosuppression.c
Script: -- : 'RUN: at line 15'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -Wl,-rpath,/mnt/disks/ssd0/agent/llvm-project/build/lib /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/parallel/parallel-nosuppression.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/parallel/Output/parallel-nosuppression.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0' /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/parallel/Output/parallel-nosuppression.c.tmp 2>&1 | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/parallel/Output/parallel-nosuppression.c.tmp.log | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/parallel/parallel-nosuppression.c

Event Timeline

Joe_Nash created this revision.Oct 1 2020, 3:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2020, 3:35 PM
Joe_Nash requested review of this revision.Oct 1 2020, 3:35 PM
rampitec accepted this revision.Oct 1 2020, 3:36 PM

LGTM

This revision is now accepted and ready to land.Oct 1 2020, 3:36 PM

I do not have commit access, please commit the patch for me.

I do not have commit access, please commit the patch for me.

I will commit it shortly.

This revision was landed with ongoing or failed builds.Oct 1 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.