Page MenuHomePhabricator

Skip -fPIE for AMDGPU and HIP toolchain
ClosedPublic

Authored by yaxunl on Mon, Sep 28, 9:11 AM.

Details

Summary

AMDGPU toolchain does not support -fPIE, therefore skip it if specified by driver.

Diff Detail

Event Timeline

yaxunl created this revision.Mon, Sep 28, 9:11 AM
yaxunl requested review of this revision.Mon, Sep 28, 9:11 AM
tra accepted this revision.Mon, Sep 28, 9:55 AM

LGTM

clang/test/Driver/hip-fpie-option.hip
35

Should there be some sort of DEV-NOT: -pic-is-pie instead? This line seems to implicitly rely on -pic-is-pie` would come before -mframe-pointer and it's not at all obvious that the key is the absence of -pic-is-pie.

This revision is now accepted and ready to land.Mon, Sep 28, 9:55 AM
yaxunl marked an inline comment as done.Mon, Sep 28, 10:36 AM
yaxunl added inline comments.
clang/test/Driver/hip-fpie-option.hip
35

will add when commit

This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Sep 28, 7:25 PM