Page MenuHomePhabricator

[AMDGPU] Add bfi immediate pattern
ClosedPublic

Authored by foad on Thu, Sep 24, 10:03 AM.

Diff Detail

Event Timeline

foad created this revision.Thu, Sep 24, 10:03 AM
foad requested review of this revision.Thu, Sep 24, 10:03 AM
arsenm added inline comments.Thu, Sep 24, 10:08 AM
llvm/lib/Target/AMDGPU/SIInstructions.td
1564

GlobalISel predicate?

foad added inline comments.Fri, Sep 25, 8:48 AM
llvm/lib/Target/AMDGPU/SIInstructions.td
1564

I could add a GISelPredicateCode but whatever I put in there won't even get compiled, let alone tested, until some of these patters actually get used by globalisel. So I'd prefer to leave it all to another patch.

arsenm added inline comments.Fri, Sep 25, 10:56 AM
llvm/lib/Target/AMDGPU/SIInstructions.td
1564

OK, I thought this was the main barrier

arsenm accepted this revision.Fri, Sep 25, 10:57 AM
This revision is now accepted and ready to land.Fri, Sep 25, 10:57 AM
This revision was landed with ongoing or failed builds.Mon, Sep 28, 2:17 AM
This revision was automatically updated to reflect the committed changes.