Page MenuHomePhabricator

[FPEnv] Use typed accessors in FPOptions
ClosedPublic

Authored by sepavloff on Wed, Sep 16, 8:11 PM.

Details

Summary

Previously methods FPOptions::get* returned unsigned value even if the
corresponding property was represented by specific enumeration type. With
this change such methods return actual type of the property. It also
allows printing value of a property as text rather than integer code.

Diff Detail

Event Timeline

sepavloff created this revision.Wed, Sep 16, 8:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptWed, Sep 16, 8:11 PM
sepavloff requested review of this revision.Wed, Sep 16, 8:11 PM
mibintc accepted this revision.Thu, Sep 17, 7:21 AM

LGTM - thanks

This revision is now accepted and ready to land.Thu, Sep 17, 7:21 AM
This revision was landed with ongoing or failed builds.Fri, Sep 18, 12:17 AM
This revision was automatically updated to reflect the committed changes.