Page MenuHomePhabricator

[clang][aarch64] Fix mangling of bfloat16 neon vectors
ClosedPublic

Authored by c-rhodes on Sep 10 2020, 9:00 AM.

Details

Summary

The AAPCS64 specifies the internal type is used for c++ mangling. For
bfloat16 it was defined as BFloat16 when it should be Bfloat16, i.e.
lowercase 'f'.

For more information, see:

https://github.com/ARM-software/abi-aa/blob/master/aapcs64/aapcs64.rst#appendix-support-for-advanced-simd-extensions

Diff Detail

Event Timeline

c-rhodes created this revision.Sep 10 2020, 9:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2020, 9:00 AM
c-rhodes requested review of this revision.Sep 10 2020, 9:00 AM
stuij accepted this revision.Sep 10 2020, 4:47 PM

Thanks, this one crept in during mass-renaming.

This revision is now accepted and ready to land.Sep 10 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.
stuij added a comment.Sep 11 2020, 3:27 AM

I'm not sure what the procedure is to get patches into LLVM 11, but I think there's still time. Could you try to get this in there as well @c-rhodes ?

I'm not sure what the procedure is to get patches into LLVM 11, but I think there's still time. Could you try to get this in there as well @c-rhodes ?

Cherry-picked into LLVM 11, see: https://bugs.llvm.org/show_bug.cgi?id=47490