Page MenuHomePhabricator

[analyzer][NFC] Introduce refactoring of PthreadLockChecker
ClosedPublic

Authored by ASDenysPetrov on Sep 4 2020, 5:33 AM.

Details

Summary
  • Change capitalization of some names due to LLVM naming rules.
  • Change names of some variables to make more speaking.
  • Rework similar bug reports into one common function.

Prepare code for the next patches to reduce unrelated changes.

Diff Detail

Event Timeline

ASDenysPetrov created this revision.Sep 4 2020, 5:33 AM
ASDenysPetrov requested review of this revision.Sep 4 2020, 5:33 AM
martong accepted this revision.Sep 4 2020, 6:16 AM

This seems to be a total non-functional-change. Please include [NFC] next time with a similar refactoring. Otherwise, Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 4 2020, 6:16 AM
ASDenysPetrov retitled this revision from [analyzer] Introduce refactoring of PthreadLockChecker to [analyzer][NFC] Introduce refactoring of PthreadLockChecker.Sep 4 2020, 8:14 AM

This seems to be a total non-functional-change. Please include [NFC] next time with a similar refactoring. Otherwise, Looks good to me, thanks!

Thanks! Added [NFC] to the title.

steakhal accepted this revision.Sep 7 2020, 8:21 AM

Seems fine to me.