Page MenuHomePhabricator

[AMDGPU] Correct documentation for default setting of sram-ecc
Needs RevisionPublic

Authored by t-tye on Aug 31 2020, 7:07 PM.

Details

Summary
  • Correct documentation for default setting of sram-ecc to ON for gfx906.

Diff Detail

Event Timeline

t-tye created this revision.Aug 31 2020, 7:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2020, 7:07 PM
t-tye requested review of this revision.Aug 31 2020, 7:07 PM
t-tye updated this revision to Diff 289060.Aug 31 2020, 7:09 PM

Correct commit heading.

t-tye retitled this revision from [AMDGPU] Correct documetnation for default setting of sram-ecc to on to [AMDGPU] Correct documentation for default setting of sram-ecc to on.Aug 31 2020, 7:10 PM
kzhuravl accepted this revision.Aug 31 2020, 7:13 PM

Might want to mention that it is being corrected for gfx906 in the commit message

This revision is now accepted and ready to land.Aug 31 2020, 7:13 PM
This revision now requires changes to proceed.Aug 31 2020, 7:34 PM
t-tye retitled this revision from [AMDGPU] Correct documentation for default setting of sram-ecc to on to [AMDGPU] Correct documentation for default setting of sram-ecc.Aug 31 2020, 8:25 PM
t-tye edited the summary of this revision. (Show Details)

So it seems the e_flags report that sram-ecc off, yet the code generated is for on.

So we should probably wait for the Target ID changes that fix these multiple bugs.