Page MenuHomePhabricator

Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`
ClosedPublic

Authored by eduucaldas on Fri, Aug 28, 5:02 AM.

Details

Summary

This allows users to use IgnoreExprNodes outside of clang/AST/Expr.cpp

Diff Detail

Event Timeline

eduucaldas created this revision.Fri, Aug 28, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Aug 28, 5:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Fri, Aug 28, 5:02 AM

This allows users to use IgnoreExprNodes outside of clang/AST/Expr.h

Did you mean "outside of Expr.cpp"?

eduucaldas edited the summary of this revision. (Show Details)Fri, Aug 28, 5:27 AM

Minor lint fixes

gribozavr2 accepted this revision.Mon, Aug 31, 9:20 AM
gribozavr2 added inline comments.
clang/include/clang/AST/IgnoreExpr.h
16

Each occurrence of unnamed namespace creates separate entities, so we would have ODR violations in IgnoreExprNodes.

38

Expand "Imp" to "Implicit"? (Here and one more below.)

This revision is now accepted and ready to land.Mon, Aug 31, 9:20 AM

Fix lint problems

eduucaldas marked an inline comment as done.

Answer comments

eduucaldas marked an inline comment as done.Mon, Aug 31, 10:13 AM