Page MenuHomePhabricator

[lldb] Fix gcc 5.4.0 compile error
ClosedPublic

Authored by DavidSpickett on Thu, Aug 27, 1:54 AM.

Details

Summary

Specify type when constructing PromotionKeys,
this fixes error:
"chosen constructor is explicit in copy-initialization"
when compiling lldb with GCC 5.4.0.

This is due to std::tuple having an explicit
default constructor, see:
http://cplusplus.github.io/LWG/lwg-defects.html#2193

Diff Detail

Event Timeline

DavidSpickett created this revision.Thu, Aug 27, 1:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 27, 1:54 AM
DavidSpickett requested review of this revision.Thu, Aug 27, 1:54 AM

https://www.llvm.org/docs/GettingStarted.html gives the minimum gcc as 5.1. (I found this cross compiling, the apt package for AArch64 is 5.4.0)

labath accepted this revision.Thu, Aug 27, 2:06 AM

Looks good.

This revision is now accepted and ready to land.Thu, Aug 27, 2:06 AM
This revision was landed with ongoing or failed builds.Thu, Aug 27, 2:23 AM
This revision was automatically updated to reflect the committed changes.