Page MenuHomePhabricator

[InstSimplify][test] Remove unused parameter in vscale.ll
ClosedPublic

Authored by aeubanks on Aug 10 2020, 1:59 PM.

Diff Detail

Event Timeline

aeubanks created this revision.Aug 10 2020, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2020, 1:59 PM
aeubanks requested review of this revision.Aug 10 2020, 1:59 PM

why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.

why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

The "same_vec_idx" refer to index "i64 4" , that's where the extractelement is extracting.
You can remove %a from function argument, that's added in error.

I think the undef should be kept.
Checking sequence insert+extract on a vector, being a existing vector, or under shouldn't matter.

aeubanks updated this revision to Diff 284505.Aug 10 2020, 2:45 PM

instead, remove unused parameter

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

The "same_vec_idx" refer to index "i64 4" , that's where the extractelement is extracting.
You can remove %a from function argument, that's added in error.

I think the undef should be kept.
Checking sequence insert+extract on a vector, being a existing vector, or under shouldn't matter.

That makes sense, thanks.

aeubanks retitled this revision from [InstSimplify][test] Remove unintended undef in vscale.ll to [InstSimplify][test] Remove unused parameter in vscale.ll.Aug 10 2020, 2:46 PM
huihuiz accepted this revision.Aug 10 2020, 2:47 PM
This revision is now accepted and ready to land.Aug 10 2020, 2:47 PM
This revision was landed with ongoing or failed builds.Aug 10 2020, 2:49 PM
This revision was automatically updated to reflect the committed changes.