Page MenuHomePhabricator

AArch64: don't sign the return address in noreturn functions
Needs ReviewPublic

Authored by t.p.northover on Aug 10 2020, 5:50 AM.

Details

Reviewers
danielkiss
Summary

A simple little change that could save a few bytes space on occasion. If a function doesn't return then signing its return address is a bit pointless.

Diff Detail

Event Timeline

t.p.northover created this revision.Aug 10 2020, 5:50 AM
t.p.northover requested review of this revision.Aug 10 2020, 5:50 AM
t.p.northover updated this revision to Diff 284332.

Add context to diff.

The produced code for the non return function might save an unsigned LR to the stack and that might be usable to craft a gadget IMHO. The probability is quite low but still.