Refactor: Simplify boolean expressions in lib/Analysis

[LegalizeAdulthood]

Summary

Simplify boolean expressions using true and false with clang-tidy

[nlewycky]

LGTM

[LegalizeAdulthood]

I don't have commit access, could someone please commit this for me? Thanks!

Patch by Richard Thomson

[dblaikie]

Committed in r233091

llvm/trunk/lib/Analysis/ScalarEvolution.cpp

 
 /// Determine whether this instruction can constant evolve within this loop
 /// assuming its operands can all constant evolve.
 static bool canConstantEvolve(Instruction *I, const Loop *L) {
   // An instruction outside of the loop can't be derived from a loop PHI.
   if (!L->contains(I)) return false;
 
   if (isa<PHINode>(I)) {
-    if (L->getHeader() == I->getParent())
-      return true;
-    else
-      // We don't currently keep track of the control flow needed to evaluate
-      // PHIs, so we cannot handle PHIs inside of loops.
-      return false;
+    return L->getHeader() == I->getParent();
   }
 
   // If we won't be able to constant fold this expression even if the operands
   // are constants, bail early.
   return CanConstantFold(I);
 }
 
 /// getConstantEvolvingPHIOperands - Implement getConstantEvolvingPHI by