Page MenuHomePhabricator

resistor (Owen Anderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 11:19 PM (431 w, 6 d)

Recent Activity

Tue, Sep 22

resistor accepted D88117: [AArch64][SVE] Fix frame offset calculation when d8 is saved..

Nice catch, LGTM.

Tue, Sep 22, 3:38 PM · Restricted Project
resistor accepted D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough.

LGTM

Tue, Sep 22, 12:10 PM · Restricted Project

Mon, Sep 21

resistor added inline comments to D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough.
Mon, Sep 21, 2:54 PM · Restricted Project

Sep 10 2020

resistor committed rG3d9c85e4d85b: Mark FMOV constant materialization as being as cheap as a move. (authored by resistor).
Mark FMOV constant materialization as being as cheap as a move.
Sep 10 2020, 9:39 AM
resistor closed D87316: Mark FMOV constant materialization as being as cheap as a move..
Sep 10 2020, 9:39 AM · Restricted Project

Sep 9 2020

resistor added a reviewer for D87316: Mark FMOV constant materialization as being as cheap as a move.: efriedma.
Sep 9 2020, 11:23 PM · Restricted Project

Sep 8 2020

resistor added a reviewer for D87316: Mark FMOV constant materialization as being as cheap as a move.: t.p.northover.
Sep 8 2020, 11:47 AM · Restricted Project
resistor requested review of D87316: Mark FMOV constant materialization as being as cheap as a move..
Sep 8 2020, 11:45 AM · Restricted Project

Sep 2 2020

resistor added a comment to D87063: [BitcodeReader] Fix O(N^2) in placeholder replacement algorithm..

If the maps are typically small, would SmallDenseMap make sense?

Sep 2 2020, 4:22 PM · Restricted Project

Sep 1 2020

resistor added a reverting change for rGbc9a29b9ee6a: Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain": rG5987da8764b7: Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain"".
Sep 1 2020, 12:29 PM
resistor committed rG5987da8764b7: Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain"" (authored by resistor).
Revert "Revert "Reapply D70800: Fix AArch64 AAPCS frame record chain""
Sep 1 2020, 12:29 PM

Aug 28 2020

resistor added a reverting change for rG6102310d814a: [InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block: rGed90f15efb40: Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block".
Aug 28 2020, 4:44 PM
resistor committed rGed90f15efb40: Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block" (authored by resistor).
Revert "[InstSimplify][EarlyCSE] Try to CSE PHI nodes in the same basic block"
Aug 28 2020, 4:44 PM

Aug 27 2020

resistor committed rGe9d9a612084b: Reapply D70800: Fix AArch64 AAPCS frame record chain (authored by resistor).
Reapply D70800: Fix AArch64 AAPCS frame record chain
Aug 27 2020, 10:30 AM
resistor closed D70800: Fix AArch64 AAPCS frame record chain.
Aug 27 2020, 10:30 AM · Restricted Project

Aug 26 2020

resistor committed rG9936455204fd: Reapply D70800: Fix AArch64 AAPCS frame record chain (authored by resistor).
Reapply D70800: Fix AArch64 AAPCS frame record chain
Aug 26 2020, 12:39 PM
resistor reopened D86387: Fix frame pointer layout on AArch64 Linux..
Aug 26 2020, 10:48 AM · Restricted Project
resistor added a reverting change for rGa0aed80b22d1: Fix frame pointer layout on AArch64 Linux.: rG9061eb8245cc: Revert "Fix frame pointer layout on AArch64 Linux.".
Aug 26 2020, 10:18 AM
resistor committed rG9061eb8245cc: Revert "Fix frame pointer layout on AArch64 Linux." (authored by resistor).
Revert "Fix frame pointer layout on AArch64 Linux."
Aug 26 2020, 10:18 AM
resistor closed D86387: Fix frame pointer layout on AArch64 Linux..

Landed as a0aed80b22d

Aug 26 2020, 9:10 AM · Restricted Project
resistor committed rGa0aed80b22d1: Fix frame pointer layout on AArch64 Linux. (authored by resistor).
Fix frame pointer layout on AArch64 Linux.
Aug 26 2020, 9:10 AM

Aug 22 2020

resistor updated the diff for D86387: Fix frame pointer layout on AArch64 Linux..

Update for comments.

Aug 22 2020, 10:34 PM · Restricted Project

Aug 21 2020

resistor added a reviewer for D86387: Fix frame pointer layout on AArch64 Linux.: t.p.northover.
Aug 21 2020, 4:45 PM · Restricted Project
resistor updated the summary of D86387: Fix frame pointer layout on AArch64 Linux..
Aug 21 2020, 4:43 PM · Restricted Project
resistor requested review of D86387: Fix frame pointer layout on AArch64 Linux..
Aug 21 2020, 4:43 PM · Restricted Project

Jul 9 2020

resistor added inline comments to D69668: Introduce a generic memset to bzero transformation in CodeGen.
Jul 9 2020, 9:02 AM · Restricted Project

Sep 2 2019

resistor committed rL370687: Request commit access for resistor.
Request commit access for resistor
Sep 2 2019, 3:08 PM

Mar 22 2019

resistor added a reviewer for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local.: mzolotukhin.
Mar 22 2019, 10:07 AM · Restricted Project

Mar 19 2019

resistor added inline comments to D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..
Mar 19 2019, 8:53 AM · Restricted Project

Mar 18 2019

resistor updated the diff for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..
Mar 18 2019, 1:53 PM · Restricted Project
resistor updated the diff for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..

Use static

Mar 18 2019, 1:52 PM · Restricted Project
resistor updated the diff for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..

Add static

Mar 18 2019, 1:52 PM · Restricted Project

Mar 16 2019

resistor updated the diff for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..

Remove unit test for ThreadLocal as well.

Mar 16 2019, 11:19 PM · Restricted Project

Mar 15 2019

resistor updated the diff for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..

Getting the repository right.

Mar 15 2019, 5:17 PM · Restricted Project
resistor changed the repository for D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local. from rG LLVM Github Monorepo to rL LLVM.
Mar 15 2019, 5:17 PM · Restricted Project
resistor created D59443: Remove the outdated ThreadLocal class in favor of C++ thread_local..
Mar 15 2019, 5:17 PM · Restricted Project

Feb 20 2019

resistor accepted D58462: Fixing NDEBUG typo in include/llvm/Support/raw_ostream.h.
Feb 20 2019, 10:14 AM · Restricted Project

May 9 2016

resistor added a comment to D20071: AMDGPU: Make some instructions convergent.

LGTM

Out of curiosity, what does making v_readlane/v_writelane convergent fix? I thought they were independent of control flow...

Now I'm not really sure about them. I was just thinking any of the instructions that do any kind of crosslane interactions would be convergent

May 9 2016, 10:54 PM

Apr 13 2016

resistor accepted D17559: AMDGPU: Implement canonicalize.

LGTM.

Apr 13 2016, 9:41 AM

Apr 8 2016

resistor added a comment to D18874: InstCombine optimization to convert floating-point sign bit XORs to fsubs from -0.0.

I'm nervous about this change. The input code is denorm preserving on architectures that flush denorms, but the output may not be.

Apr 8 2016, 10:40 AM

Apr 7 2016

resistor added a comment to D18513: Simplify isfinite/isnan/isinf in finite-math-only mode.

I agree with Steve here. Even code that is built with -ffast-math has to live in a reality where NaNs, Infs, etc. are sometimes generated by external function calls, provided as user input, etc. It's critical that this code be able to filter out these invalid values, precisely because the body of the code will be optimized on the assumption that those values did not need to be considered.

Apr 7 2016, 11:03 AM

Apr 1 2016

resistor added a comment to D18670: LoopUnroll: some small fixes/tweaks to make it more useful for partial unrolling.

It feels wrong to bloat the commandline options like this, I guess

Apr 1 2016, 3:40 PM
resistor added a comment to D18670: LoopUnroll: some small fixes/tweaks to make it more useful for partial unrolling.

But now in LLVM trunk there is no way to make FullUnrollMaxCount 6. Right?
To make FullUnrollMaxCount introduction reasonable there should be a path in LLVM trunk where FullUnrollMaxCount can become something else than UINT_MAX. That will resolve the issue with test as well.

Apr 1 2016, 3:14 PM

Mar 29 2016

resistor accepted D17223: LegalizeDAG: Don't replace vector store with integer if not legal.

LGTM

Mar 29 2016, 12:36 PM
resistor accepted D17222: LegalizeDAG: Don't replace vector load with integer unless legal.

LGTM

Mar 29 2016, 12:35 PM

Mar 21 2016

resistor added a comment to D17223: LegalizeDAG: Don't replace vector store with integer if not legal.

Needs doxygen comment.

Mar 21 2016, 11:03 AM
resistor added a comment to D17222: LegalizeDAG: Don't replace vector load with integer unless legal.

Code change is fine, but I would like to see a doxygen comment for scalarizeVectorLoad()

Mar 21 2016, 11:02 AM

Mar 1 2016

resistor added a comment to D17778: TypedError for recoverable error handling.

Hi Lang,

Mar 1 2016, 1:29 PM
resistor accepted D17205: DAGCombiner: Turn truncate of a bitcasted vector to an extract.

LGTM.

Mar 1 2016, 12:48 PM
resistor closed D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic..

r262376

Mar 1 2016, 11:41 AM
resistor committed rL262376: Fix an issue where fast math flags were dropped during scalarization..
Fix an issue where fast math flags were dropped during scalarization.
Mar 1 2016, 11:40 AM
resistor added a comment to D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic..

Ping?

Mar 1 2016, 9:58 AM

Feb 27 2016

resistor updated the diff for D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic..

Added new CreateWithCopiedFlags() on BinaryOperator.

Feb 27 2016, 10:32 PM

Feb 26 2016

resistor added inline comments to D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic..
Feb 26 2016, 11:05 AM
resistor added a reviewer for D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic.: arsenm.
Feb 26 2016, 9:43 AM

Feb 25 2016

resistor committed rL261934: More internal details of SROA pass to library visibility..
More internal details of SROA pass to library visibility.
Feb 25 2016, 3:39 PM
resistor closed D16486: Strip local symbols when using externalized debug info..
Feb 25 2016, 11:06 AM

Feb 24 2016

resistor retitled D17585: Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic. from to Fix failure of InstCombine to propagate fast math flags when scalarizing vector arithmetic..
Feb 24 2016, 4:09 PM

Feb 23 2016

resistor added inline comments to D17141: [ARM] Adding IEEE-754 SIMD detection to loop vectorizer.
Feb 23 2016, 11:54 AM

Feb 20 2016

resistor added a comment to D17430: [ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv..

Ok, I see what you're trying to get at, and I agree with your assessment that a it is removing a control dependence. Since it's specific to exactly the transform being applied, I think a little deeper explanation in the comment is merited.

Feb 20 2016, 9:01 PM

Feb 19 2016

resistor added a comment to D17430: [ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv..

I don't agree with the new comments. If conversion does not remove any dependencies. It just changes their expression from control flow to predication, but they're still control dependencies in that they gate execution.

Feb 19 2016, 4:02 PM

Feb 18 2016

resistor added a comment to D17429: Don't mark convergent instructions as trivially rematerializable..

I have convergent instructions that are essentially register->register arithmetic operations. I don't have any great dependence on them being rematerialized, but I wanted to point out that it's not inconceivable.

Feb 18 2016, 9:31 PM
resistor added a comment to D17430: [ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv..

If-conversion doesn't change the control dependencies of the MIs that it moves. It just changes the expression of the dependency from expression via branches to expression via predication. Either way, the execution of the convergent op is still gated by the same set of expressions. Hence, I don't think any change is needed here.

Feb 18 2016, 9:30 PM
resistor added a comment to D17430: [ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv..

Why is this needed?

Feb 18 2016, 9:11 PM
resistor added a comment to D17429: Don't mark convergent instructions as trivially rematerializable..

My targets have convergent instructions that are rematerializable.

Feb 18 2016, 8:20 PM

Feb 17 2016

resistor retitled D17347: Use LLVM_LIBRARY_VISIBILITY to prevent LLVM dynamic libraries from export symbols for SROA internals. from to Use LLVM_LIBRARY_VISIBILITY to prevent LLVM dynamic libraries from export symbols for SROA internals..
Feb 17 2016, 1:21 PM
resistor accepted D17340: SelectionDAG: Use correct addrspace when lowering memcpy.

LGTM.

Feb 17 2016, 10:13 AM

Feb 16 2016

resistor added a comment to D17304: Fix quadratic spill behavior?.

Do you have any suggestions on how a target might make a reasonable choice for the limit? Does the limit trend down as the size of the register file goes up?

Feb 16 2016, 1:57 PM

Feb 12 2016

resistor added a comment to D17141: [ARM] Adding IEEE-754 SIMD detection to loop vectorizer.

It *does* depend on the OS running underneath, and I'm providing an example right here. This is comparable to the fact that many implementations do not provide sNaN support.

I'm not sure I understand. Are you talking about Apple's implementation of the SIMD unit, or about the OS setting up some different flags?

AFAIK, you can't "turn on" IEEE compliance on NEON with hardware flags. So, if you accept non-IEEE-compliant code in Darwin (the OS?) becomes a platform decision, not a hardware requirement. This flag is about the hardware requirement.

Feb 12 2016, 12:16 PM
resistor added a comment to D17141: [ARM] Adding IEEE-754 SIMD detection to loop vectorizer.

That's not correct for all platforms. Darwin, for example, uses NEON for floating point even in non-fast-math mode. The platform is simply defined not to support subnormals.

Well, NEON denormal behaviour is independent of the OS running underneath, so this is the correct information. But it may not be the best decision for Darwin, and that's a separate story.

Feb 12 2016, 11:13 AM
resistor added a comment to D17141: [ARM] Adding IEEE-754 SIMD detection to loop vectorizer.

That's not correct for all platforms. Darwin, for example, uses NEON for floating point even in non-fast-math mode. The platform is simply defined not to support subnormals.

Feb 12 2016, 10:41 AM

Feb 10 2016

resistor added a comment to D17065: Defer CWD in MCContext lookup as late as possible..

That makes sense to me in principle, but I know nothing of why CWD is needed for (some form of?) DWARF generation at all.

Feb 10 2016, 10:42 AM

Feb 9 2016

resistor retitled D17065: Defer CWD in MCContext lookup as late as possible. from to Defer CWD in MCContext lookup as late as possible..
Feb 9 2016, 11:13 PM
resistor accepted D17017: SelectionDAG: Make Properties a field of SDPatternOperator.

LGTM.

Feb 9 2016, 9:49 PM
resistor accepted D17016: SelectionDAG: Make min/max commutative and associative.

LGTM.

Feb 9 2016, 9:48 PM

Feb 8 2016

resistor accepted D17012: Update document about convergent attribute..

LGTM.

Feb 8 2016, 9:04 PM

Jan 29 2016

resistor accepted D16740: [SelectionDAG] Eliminate exponential behavior in WalkChainUsers.

Functionality LGTM. I would add a comment at the use site of TokenFactorResult to point out that the walk is being memoized.

Jan 29 2016, 4:05 PM

Jan 22 2016

resistor committed rL258566: Strip local symbols when using externalized debug info..
Strip local symbols when using externalized debug info.
Jan 22 2016, 2:11 PM
resistor retitled D16486: Strip local symbols when using externalized debug info. from to Strip local symbols when using externalized debug info..
Jan 22 2016, 1:55 PM

Jan 10 2016

resistor updated subscribers of D15918: Fix ownership of FileManager in Tools.
Jan 10 2016, 11:43 PM
resistor retitled D16041: Change vfs::FileSystem to be managed with std::shared_ptr from to Change vfs::FileSystem to be managed with std::shared_ptr.
Jan 10 2016, 11:42 PM

Jan 9 2016

resistor added a comment to D15918: Fix ownership of FileManager in Tools.

I made an attempt to remove ownership from CompilerInstance, but ASTUnit has a massively complex relationship with FileManager, and foiled my attempt.

Jan 9 2016, 8:35 PM

Jan 7 2016

resistor added a comment to D15918: Fix ownership of FileManager in Tools.

I am not comfortable authoring a patch to do that, as I don't have a clear understanding of the clients involved, and have no means to verify its correctness.

Jan 7 2016, 9:50 AM

Jan 6 2016

resistor added a comment to D15918: Fix ownership of FileManager in Tools.

! In D15918#320308, @klimek wrote:

I understand - my question is, why not instead take away ownership from CompilerInstance?

Jan 6 2016, 10:19 AM
resistor added a comment to D15918: Fix ownership of FileManager in Tools.

Thx for fixing. What's the reason that the CompilerInstance wants ownership?

Jan 6 2016, 12:55 AM
resistor added reviewers for D15918: Fix ownership of FileManager in Tools: klimek, bkramer.
Jan 6 2016, 12:51 AM
resistor updated D15918: Fix ownership of FileManager in Tools.
Jan 6 2016, 12:50 AM
resistor added a reviewer for D15918: Fix ownership of FileManager in Tools: chandlerc.
Jan 6 2016, 12:48 AM
resistor retitled D15918: Fix ownership of FileManager in Tools from to Fix ownership of FileManager in Tools.
Jan 6 2016, 12:48 AM

Dec 10 2015

resistor added a comment to D15348: [DAGCombiner] Handle pre/post-inc stores in replaceStoreChain.

Your proposed fix seems conservatively correct to me. I'd recommend getting a review from one of the ARM maintainers, perhaps tnorthover?

Dec 10 2015, 1:01 PM

Nov 20 2015

resistor committed rL253723: Fix another infinite loop in Reassociate caused by Constant::isZero()..
Fix another infinite loop in Reassociate caused by Constant::isZero().
Nov 20 2015, 2:37 PM
resistor committed rL253655: Fix a pair of issues that caused an infinite loop in reassociate..
Fix a pair of issues that caused an infinite loop in reassociate.
Nov 20 2015, 12:18 AM

Nov 16 2015

resistor committed rL253240: Add intermediate subtract instructions to reassociation worklist..
Add intermediate subtract instructions to reassociation worklist.
Nov 16 2015, 10:10 AM

Nov 12 2015

resistor added a comment to D12345: [Reassociate]: Add intermediate subtract instructions created while negating to be redone later for more reassociate opportunities.

The last status i saw was: "I'll try seeing what little needs to be done to
converge in the couple cases that I have (one above) and a superficial look
at why the second reassociate improves codegen."

I saw no update on that ;-)

Nov 12 2015, 11:55 PM
resistor added a comment to D12345: [Reassociate]: Add intermediate subtract instructions created while negating to be redone later for more reassociate opportunities.

Ping? Was there any further feedback on this? We're seeing pretty horrible regressions caused by this.

Nov 12 2015, 2:48 PM

Nov 10 2015

resistor accepted D14248: LegalizeDAG: Implement promote for scalar_to_vector.
Nov 10 2015, 10:19 AM
resistor added a comment to D14248: LegalizeDAG: Implement promote for scalar_to_vector.

Patch LGTM. Testcase?

Nov 10 2015, 10:18 AM
resistor accepted D14247: LegalizeDAG: Implement promote for insert_vector_elt.

Patch LGTM. Testcase?

Nov 10 2015, 10:18 AM
resistor accepted D14246: LegalizeDAG: Implement promote for extract_vector_elt.

Patch looks LGTM. Is it possible to provide a test case, maybe for AMDGPU?

Nov 10 2015, 10:18 AM

Oct 19 2015

resistor committed rL250726: Restore the original behavior of SelectionDAG::getTargetIndex()..
Restore the original behavior of SelectionDAG::getTargetIndex().
Oct 19 2015, 12:29 PM